os/bluestore: fix duplicate allocations in bmap allocator #28496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: http://tracker.ceph.com/issues/40080 Signed-off-by: Igor Fedotov <ifedotov@suse.com>
This is rather a template to build custom troubleshooters for bitmap allocator using existing logs. Tool replays OSD log to build allocator state that caused an issue. Signed-off-by: Igor Fedotov <ifedotov@suse.com>
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
liewegas
reviewed
Jun 11, 2019
src/os/bluestore/BitmapAllocator.cc
Outdated
| @@ -36,7 +36,7 @@ int64_t BitmapAllocator::allocate( | |||
| } | |||
| for (auto e : *extents) { | |||
| ldout(cct, 10) << __func__ | |||
| << " 0x" << std::hex << e.offset << "~" << e.length | |||
| << "extent: 0x" << std::hex << e.offset << "~" << e.length | |||
There was a problem hiding this comment.
missing space between e.length and 'extent'?
liewegas
approved these changes
Jun 11, 2019
liewegas
approved these changes
Jun 11, 2019
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
ifed01
force-pushed
the
wip-ifed-fix-40080
branch
from
79bd26e
to
a90d57c
Compare
|
retest this please. |
1 similar comment
|
retest this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/40080
Signed-off-by: Igor Fedotov ifedotov@suse.com