debian/control: add python-routes dependency for dashboard #28835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
|
@emmericp could update the commit message to note that this runtime dependency is introduced by cherrypy/_cpdispatch.py ? |
the dashboard requires python-routes via cherrypy/_cpdispatch.py during runtime but the cherrypy debian package only recommends it and doesn't depend on it Fixes: https://tracker.ceph.com/issues/24420 Signed-off-by: Paul Emmerich <paul.emmerich@croit.io>
|
done |
|
retest this please |
tchaikov
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our build broken because we only had python-routes installed by coincident, some unrelated change in our image removed the dependency on python-routes.
This patch ensures that python-routes is always installed
https://tracker.ceph.com/issues/24420