osd: a few fixes for the removed_snaps changes #28865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't put this in the snapmapper object because filestore does not allow multiple concurrent omap iterators on the same object. (This is a limitation that could be fixed with some read/write locking, but not without some significant changes to DBObjectMap; since that is old crufty legacy code let's avoid touching it!) Signed-off-by: Sage Weil <sage@redhat.com>
If we leak snaps, failing to clean up a namespace can happen and won't get fixed until we scrub purged_snaps. Make this a non-fatal condition. Signed-off-by: Sage Weil <sage@redhat.com>
We don't want to get false positives from keys for other pools. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
added a commit
that referenced
this pull request
Jul 4, 2019
* refs/pull/28865/head: mon/OSDMonitor: fix _lookup_snap to verify the pool matches ceph_test_rados_api_*: make failing to clean up namespace non-fatal osd: store purged_snaps history under separate object Reviewed-by: Samuel Just <sjust@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #28330