-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgr/dashboard: Add linter for unclosed HTML tags #28916
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tspmelo
reviewed
Jul 8, 2019
alfonsomthd
approved these changes
Jul 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes: http://tracker.ceph.com/issues/40686 Signed-off-by: Patrick Nawracay <pnawracay@suse.com>
jenkins retest this please |
tspmelo
approved these changes
Jul 15, 2019
jenkins test make check |
@p-na make check is failing due to a missing
|
Signed-off-by: Patrick Nawracay <pnawracay@suse.com>
ricardoasmarques
approved these changes
Jul 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
html-hint
to thenpm run lint
command and hence, it's automatically added torun-frontend-unit-test.sh
, which is called on pull request creation. Ensures closed HTML tags. It found the issue spotted by @s0nea.Fixes: http://tracker.ceph.com/issues/40686
Signed-off-by: Patrick Nawracay pnawracay@suse.com