Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mimic: core: should report EINVAL in ErasureCode::parse() if m<=0 #28995

Merged
merged 3 commits into from Jul 18, 2019
Merged

mimic: core: should report EINVAL in ErasureCode::parse() if m<=0 #28995

merged 3 commits into from Jul 18, 2019

Commits on Jul 11, 2019

  1. mon/OSDMonitor: set ec min_size to k + min(1, m - 1) 

    Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 7f49be2)
    @liewegas @smithfarm
    liewegas authored and smithfarm committed Jul 11, 2019
    Copy the full SHA
    d97e97b View commit details
    Browse the repository at this point in the history

  2. erasure-code: ensure m >= 1 

    Fixes: http://tracker.ceph.com/issues/38682
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit ab0a652)

Conflicts:
	src/erasure-code/clay/ErasureCodeClay.cc
- file does not exist in mimic
    @liewegas @smithfarm
    liewegas authored and smithfarm committed Jul 11, 2019
    Copy the full SHA
    365ec76 View commit details
    Browse the repository at this point in the history

  3. qa/standalone/erasure-code/test-erasure-code: adjust test to avoid m=0 

    _DD is k=2 m=0, which we don't allow.  Switch it to cDD.

I confess I don't fully understand why this was _DD to begin with, but
I'm pretty sure mapping is there to control the order of results so that
it can be mapped to the CRUSH rule output sanely, and the coding portion
is not relevant to the test.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 52d5797)
    @liewegas @smithfarm
    liewegas authored and smithfarm committed Jul 11, 2019
    Copy the full SHA
    8afc133 View commit details
    Browse the repository at this point in the history