-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src/: s/Mutex/ceph::mutex/ #29113
src/: s/Mutex/ceph::mutex/ #29113
Conversation
\o/ |
6ccfb83
to
6f9ced4
Compare
jenkins, retest this please |
a6fde61
to
7ddc3b0
Compare
@@ -33,11 +33,7 @@ class SafeTimerThread : public Thread { | |||
}; | |||
|
|||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point it might be better just to use replace all our uses of Timer.cc with ceph_timer.h, since it already uses the new concurrency, time, functions, etc,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, we could make that change in another PR. i think we could even deprecate utime in future, and just use it as an ondisk/wire format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that conversion from SafeTimer to ceph::timer isn't trivial in cases that rely on the "Safe" part
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
for using functions like `lockdep_unregister_ceph_context()` Signed-off-by: Kefu Chai <kchai@redhat.com>
`PG` print details info in the prefix of logging messages if the PG is being locked by current thread. but `ceph::mutex` is an alias of `std::mutex` in non-debug mode, so neither `mutex::is_locked_by_me()` nor `mutex::is_locked()` is supported in non-debug mode. to continue supporting this feature, `PG::locked_by` is added to memorize the thread id of the owner of the lock. Signed-off-by: Kefu Chai <kchai@redhat.com>
as it's replaced by ceph::condition_variable. Signed-off-by: Kefu Chai <kchai@redhat.com>
as it's replaced by `ceph::mutex` Signed-off-by: Kefu Chai <kchai@redhat.com>
2a489c4
to
dc21fd0
Compare
@tchaikov
Likely due to a missing |
@tchaikov
Have been trying all kinds of things but I keep getting mismatching function signatures... |
vector<mutex_pointer>
withceph::containers::tiny_vector<>