Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luminous: tools: Add clear-data-digest command to objectstore tool #29212

Closed
wants to merge 1 commit into from
Closed

luminous: tools: Add clear-data-digest command to objectstore tool #29212

wants to merge 1 commit into from

Conversation

smithfarm
Copy link
Contributor

@liyichao @smithfarm
tools: Add clear-data-digest command to objectstore tool.
dffbc8f 
There may be a situation where data digest in object info is
inconsistent with that computed from object data, then deep-scrub
will fail even though all three repicas have the same object data.

Fixes: https://tracker.ceph.com/issues/37935

Signed-off-by: Li Yichao <liyichao.good@gmail.com>
(cherry picked from commit da5832b)

Conflicts:
    src/tools/ceph_objectstore_tool.cc
- change cbegin() to begin() to get it to build
@smithfarm smithfarm self-assigned this Jul 23, 2019
@smithfarm smithfarm added this to the luminous milestone Jul 23, 2019
@smithfarm smithfarm changed the title luminous: Add clear-data-digest command to objectstore tool luminous: tools: Add clear-data-digest command to objectstore tool Jul 23, 2019
dzafman
dzafman approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@dzafman dzafman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure this passes:

../qa/run-standalone.sh ceph_objectstore_tool.py

@smithfarm
Copy link
Contributor Author 

/home/jenkins-build/build/workspace/ceph-pull-requests/src/tools/ceph_objectstore_tool.cc: In function ‘int clear_data_digest(ObjectStore*, coll_t, ghobject_t&)’:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/tools/ceph_objectstore_tool.cc:2588:50: error: no matching function for call to ‘ObjectStore::queue_transaction(boost::intrusive_ptr<ObjectStore::CollectionImpl>&, std::remove_reference<ObjectStore::Transaction&>::type)’
     r = store->queue_transaction(ch, std::move(t));
                                                  ^
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/tools/ceph_objectstore_tool.cc:28:0:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/os/ObjectStore.h:1473:7: note: candidate: int ObjectStore::queue_transaction(ObjectStore::Sequencer*, ObjectStore::Transaction&&, Context*, Context*, Context*, TrackedOpRef, ThreadPool::TPHandle*)
   int queue_transaction(Sequencer *osr, Transaction&& t, Context *onreadable, Context *ondisk=0,
       ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/os/ObjectStore.h:1473:7: note:   candidate expects 7 arguments, 2 provided
/home/jenkins-build/build/workspace/ceph-pull-requests/src/os/ObjectStore.h:1510:7: note: candidate: int ObjectStore::queue_transaction(ObjectStore::Sequencer*, ObjectStore::Transaction&&, Context*, Context*, Context*, Context*, TrackedOpRef)
   int queue_transaction(
       ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/os/ObjectStore.h:1510:7: note:   candidate expects 7 arguments, 2 provided
src/tools/CMakeFiles/ceph-objectstore-tool.dir/build.make:62: recipe for target 'src/tools/CMakeFiles/ceph-objectstore-tool.dir/ceph_objectstore_tool.cc.o' failed
make[3]: *** [src/tools/CMakeFiles/ceph-objectstore-tool.dir/ceph_objectstore_tool.cc.o] Error 1

@smithfarm
Copy link
Contributor Author

Something is missing - does not build.

@smithfarm smithfarm closed this Jul 25, 2019
@dzafman
Copy link
Contributor

dzafman commented Jul 26, 2019

See #29366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzafman dzafman dzafman approved these changes

@neha-ojha neha-ojha Awaiting requested review from neha-ojha

Assignees

@smithfarm smithfarm

Labels
tools
Projects
None yet
Milestone
luminous
3 participants
@smithfarm @dzafman @liyichao