luminous: tools: Add clear-data-digest command to objectstore tool. #29366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There may be a situation where data digest in object info is inconsistent with that computed from object data, then deep-scrub will fail even though all three repicas have the same object data. Fixes: https://tracker.ceph.com/issues/37935 Signed-off-by: Li Yichao <liyichao.good@gmail.com> (cherry picked from commit da5832b) Adjustments for luminous: Add ObjectStore::Sequencer Use begin() instead of cbegin() Eliminate use of open_collection()
smithfarm
reviewed
Aug 19, 2019
There was a problem hiding this comment.
Thanks for including descriptions of the manual adjustments you made, but the commit message is missing this text:
Conflicts:
qa/standalone/special/ceph_objectstore_tool.py
src/tools/ceph_objectstore_tool.cc
(of course, you would only include the files that actually had cherry-pick conflicts)
|
@smithfarm There weren't any cherry-pick conflicts, so I having "Conflicts:" doesn't apply. |
neha-ojha
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.ceph.com/issues/37748
There may be a situation where data digest in object info is
inconsistent with that computed from object data, then deep-scrub
will fail even though all three repicas have the same object data.
Fixes: https://tracker.ceph.com/issues/37935
Signed-off-by: Li Yichao liyichao.good@gmail.com
(cherry picked from commit da5832b)
Adjustments for luminous:
Add ObjectStore::Sequencer
Use begin() instead of cbegin()
Eliminate use of open_collection()