Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mimic: rgw: swift object expiry fails when a bucket reshards #29258

Merged
merged 9 commits into from
Oct 11, 2019
Merged

mimic: rgw: swift object expiry fails when a bucket reshards #29258

merged 9 commits into from
Oct 11, 2019

Commits on Oct 1, 2019

  1. doc: add troubleshooting notes on reshard admin clis 

    Adding a note on LC fixes and reshard stale instance fixes

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit dee9ac2)
    @theanalyst @smithfarm
    theanalyst authored and smithfarm committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    1b28adb View commit details
    Browse the repository at this point in the history

  2. rgw: updates to resharding documentation 

    Some minor updates to the resharding documentation with the aim of
clarifying the language and using terms consistently.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit 54b6b65)
    @ivancich @smithfarm
    ivancich authored and smithfarm committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    74b8648 View commit details
    Browse the repository at this point in the history

  3. doc: add a troubleshooting note on resharding expirer fixes 

    Added a note about the commands added to support stale expired object deletion

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit 40bf082)
    @theanalyst @smithfarm
    theanalyst authored and smithfarm committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    b177dda View commit details
    Browse the repository at this point in the history

  4. doc: add a note on reshard object expirer fixes in PendingReleaseNotes 

    Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from ef8329f)

Conflicts:
    PendingReleaseNotes
    @theanalyst @smithfarm
    theanalyst authored and smithfarm committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    0f0c98f View commit details
    Browse the repository at this point in the history

  5. rgw: object expirer: handle resharded buckets 

    Previously we fetched the bucket instance info which changes during a reshard
causing the bucket info to fail, since the subsequent checks will assume that
would mean a deleted bucket, the expiry hint is purged as well, leaving a non
deleted object as well as a deleted hint. This should fix newer runs of object
expiry processes. Finding out stale expired objects will require more complex
rgw-admin tooling support

Fixes: https://tracker.ceph.com/issues/39495
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit 7f958c6)
    @theanalyst @smithfarm
    theanalyst authored and smithfarm committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    d256b92 View commit details
    Browse the repository at this point in the history

  6. rgw: rgw_bucket: set BucketInfo as const in rgw_remove_object 

    Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit 1d1ea1f)
    @theanalyst @smithfarm
    theanalyst authored and smithfarm committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    5a1cddf View commit details
    Browse the repository at this point in the history

  7. rgw_common: introduce a decode_bl function to decode a bl to type 

    Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit 5e56ea6)

Conflicts:
	src/rgw/rgw_common.h
- no "static inline string rgw_bl_str" in mimic
- cbegin -> begin
    @theanalyst @smithfarm
    theanalyst authored and smithfarm committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    b0e3195 View commit details
    Browse the repository at this point in the history

  8. rgw: admin: introduce objects expire-stale list and rm 

    These commands help cleanup stale expired objects after a reshard has happened
Contains the following changesets:

* rgw_bucket: add a AdminOp function to cleanup stale expired objects
There is also a dry run option, which will allow listing to just view the
objects before we actually delete them
* rgw_bucket: introduce rgw_object_get_attr helper function
Since this could be re-used across other functions that try to get a single
xattr, both get acl and the new object expire stale commands now use this
function to read the value of a single xattr

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit d4c462a)

Conflicts:
    src/rgw/rgw_admin.cc
- no strcmp(cmd, "event") in mimic
    src/rgw/rgw_bucket.cc
- adapt to mimic
    src/rgw/rgw_bucket.h
- no "fix_lc_shards" in mimic
    @theanalyst @smithfarm
    theanalyst authored and smithfarm committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    35554f6 View commit details
    Browse the repository at this point in the history

  9. rgw: add const to some RGWBucketInfo helpers 

    Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 5c0ee28)
    @cbodley @smithfarm
    cbodley authored and smithfarm committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    0e53929 View commit details
    Browse the repository at this point in the history