pybind/mgr/restful: use dict.items() for py3 compatible #29356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-philipp
approved these changes
Jul 29, 2019
src/pybind/mgr/restful/common.py
Outdated
| @@ -34,7 +36,7 @@ | |||
| def humanify_command(command): | |||
| out = [command['prefix']] | |||
|
|
|||
| for arg, val in command.iteritems(): | |||
| for arg, val in six.iteritems(command): | |||
There was a problem hiding this comment.
if this is not critical, we might just use
Suggested change
| for arg, val in six.iteritems(command): | |
| for arg, val in command.items(): |
instead.
There was a problem hiding this comment.
i am fine with either of these two approaches as long as we don't care about creating a copy of command in python2.
Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-mgr/restful
branch
from
019444b
to
a46292b
Compare
|
@sebastian-philipp updated and repushed. |
|
(still approve) |
tchaikov
changed the title
liewegas
added a commit
that referenced
this pull request
Jul 31, 2019
* refs/pull/29356/head: pybind/mgr/restful: use dict.items() for py3 compatibility Reviewed-by: Sebastian Wagner <swagner@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kefu Chai kchai@redhat.com