os/bluestore/BlueFS: use 64K alloc_size on the shared device #29537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
force-pushed
the
wip-bluefs-shared-alloc
branch
from
52eb067
to
dfd97b8
Compare
|
needs a rebase since #29425 merged |
ifed01
approved these changes
Aug 7, 2019
|
needs rebase |
jdurgin
approved these changes
Aug 7, 2019
jdurgin
reviewed
Aug 7, 2019
| .set_description(""), | ||
| .set_description("Allocation unit size for DB and WAL devices"), | ||
|
|
||
| Option("bluefs_shared_alloc_size", Option::TYPE_SIZE, Option::LEVEL_ADVANCED) |
3 tasks
liewegas
force-pushed
the
wip-bluefs-shared-alloc
branch
from
dfd97b8
to
3667cc1
Compare
|
I'm heading out for the day, can you queue up a test? Thanks!
|
sure! |
|
the make check failure in unittest_bluefs looks related |
|
http://pulpito.ceph.com/nojha-2019-08-08_00:28:04-rados-wip-bluefs-shared-alloc-distro-basic-smithi/ - lot of test failures due to |
liewegas
force-pushed
the
wip-bluefs-shared-alloc
branch
from
3667cc1
to
e03e743
Compare
|
fixed
|
|
@neha-ojha should i cherry-pick 8128240 here too? |
don't think that'll be required, "bluefs_alloc_size" will still be 1Mb |
|
cbt errors are due to a regression introduced in ceph/cbt#178. We merged ceph/cbt#182 yesterday which turned out to be an incomplete fix. ceph/cbt#184 should be a better fix until we introduce a better settings hierarchy. |
Signed-off-by: Neha Ojha <nojha@redhat.com>
Add a separate config option that controls the alloc_size for the shared device (BDEV_SLOW). Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-bluefs-shared-alloc
branch
from
9bdbffa
to
f7233ba
Compare
ifed01
reviewed
Aug 9, 2019
| << " from " << (int)dev_target << dendl; | ||
| return -EIO; | ||
| } | ||
| rewrite = true; |
Keep an alloc_size vector so that we have this value handy at all times. Allow bluestore to fetch this value directly instead of looking at the bluefs_* config options since this encapsulates things a bit better, and also isn't vulnerable to the config setting changing at runtime. Signed-off-by: Sage Weil <sage@redhat.com>
…sizes The previous implementation moved extents individually. This caused problems when moving an extent with a small alloc_size that wasn't a multiple of the target device's alloc_size. Instead, identify files with extents that need to be moved, and then read the file in its entirety and rewrite it in its entirety. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-bluefs-shared-alloc
branch
from
7baa22e
to
9426974
Compare
liewegas
added a commit
that referenced
this pull request
Aug 15, 2019
* refs/pull/29537/head: os/bluestore/BlueFS: fix device_migrate_to_* to handle varying alloc sizes os/bluestore/BlueFS: apply shared_alloc_size to shared device os/bluestore: whitespace os/bluestore/BlueFS: add bluefs_shared_alloc_size os/bluestore/BlueStore.cc: start should be >= _get_ondisk_reserved() Reviewed-by: Igor Fedotov <ifedotov@suse.com> Reviewed-by: Josh Durgin <jdurgin@redhat.com> Reviewed-by: Neha Ojha <nojha@redhat.com>
This was referenced Aug 19, 2019
3 tasks
This was referenced Aug 24, 2019
|
@vumrao ^ |
|
I see there are also trackers. . . uff. Will try to get this cleaned up. |
|
@smithfarm Yes, mimic/luminous have little different handling as Josh mentioned in his commit(b5de477). Looks like now all taken care. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shared devices is susceptible to fragmentation, making the 1 MB bluefs allocations fail. Use a smaller allocation size (64K) for the shared device, while keeping the same large allocations for DB and WAL.
master tracker: https://tracker.ceph.com/issues/41301
Backports:
nautilus #30229
mimic #30219
luminous #29910