ceph-volume: never log to stdout, use stderr instead #29547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Follow up to #27675 |
jan--f
force-pushed
the
c-v-always-log-to-stdout
branch
2 times, most recently
from
ef1d053
to
882d9ba
Compare
|
Not sure what's up with the one failing test. Works locally for both python2 and 3. |
|
This looks OK. I think we should probably contemplate migrating over to the logging module at some point if there is another problem like this one. |
alfredodeza
approved these changes
Aug 8, 2019
jan--f
force-pushed
the
c-v-always-log-to-stdout
branch
2 times, most recently
from
b016cc4
to
0f64ad3
Compare
We should never print log messages to stdout, as this should be reserved for output of ceph-volume. Fixes: https://tracker.ceph.com/issues/41158 Signed-off-by: Jan Fajerski <jfajerski@suse.com>
jan--f
force-pushed
the
c-v-always-log-to-stdout
branch
from
0f64ad3
to
b8d6dcb
Compare
|
jenkins test ceph-volume tox |
This was referenced Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should never print log messages to stdout, as this should be reserved
for output of ceph-volume.
Fixes: https://tracker.ceph.com/issues/41158
Signed-off-by: Jan Fajerski jfajerski@suse.com