os/bluestore: expand lttng tracepoints, improve fio_ceph_objectstore backend #29674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please. |
athanatos
changed the title
athanatos
requested review from
ifed01 and
aclamk
and removed request for
tchaikov,
jdurgin and
rzarzynski
3 tasks
aclamk
reviewed
Aug 23, 2019
tchaikov
requested changes
Aug 25, 2019
athanatos
force-pushed
the
sjust/wip-fio-trace
branch
from
d0bf509
to
02b815d
Compare
|
retest this please |
athanatos
force-pushed
the
sjust/wip-fio-trace
branch
2 times, most recently
from
f8582cc
to
8f572d9
Compare
|
@athanatos needs rebase. |
athanatos
force-pushed
the
sjust/wip-fio-trace
branch
from
8f572d9
to
b9951d7
Compare
|
@tchaikov rebased |
|
Ok, I think I've addressed your comments. For the cmake bit, I added a cmakedefine for EVENTTRACE, made it depend on LTTNG, and cleaned up all of the code and cmake conditionals to only check EVENTTRACE. |
tchaikov
reviewed
Sep 26, 2019
|
please note, some of my comments are folded by GitHub web UI. |
athanatos
force-pushed
the
sjust/wip-fio-trace
branch
from
6aea329
to
01a861e
Compare
|
Sorry, I did indeed miss those. |
athanatos
force-pushed
the
sjust/wip-fio-trace
branch
from
01a861e
to
42d985d
Compare
tchaikov
approved these changes
Sep 26, 2019
src/common/ceph_time.h
Outdated
| } | ||
|
|
||
| template<typename Target, typename T> | ||
| static uint64_t to_microseconds(T t) { |
src/common/ceph_time.h
Outdated
| @@ -503,6 +503,20 @@ struct converts_to_timespec<Clock, std::void_t<decltype( | |||
| template <typename Clock> | |||
| constexpr bool converts_to_timespec_v = converts_to_timespec<Clock>::value; | |||
|
|
|||
| template<typename Target, typename T> | |||
| static double to_seconds(T t) { | |||
aclamk
approved these changes
Sep 26, 2019
| Option("bluestore_throttle_trace_rate", Option::TYPE_FLOAT, Option::LEVEL_ADVANCED) | ||
| .set_default(0) | ||
| .set_description(""), | ||
|
|
There was a problem hiding this comment.
I think these options contain 'debug'.
There was a problem hiding this comment.
I'm not sure what you mean. I've added a description though.
athanatos
force-pushed
the
sjust/wip-fio-trace
branch
3 times, most recently
from
a00a5af
to
ae1eead
Compare
|
retest this please |
1 similar comment
|
retest this please |
…to file Signed-off-by: Samuel Just <sjust@redhat.com>
Because EVENTTRACE now implies LTTNG, also cleanup EVENTTRACE conditions to assume LTTNG. Also add missing eventtrace dependencies to rbd and test/objectstore. Signed-off-by: Samuel Just <sjust@redhat.com>
By nature, these tend to be extremely high volume. Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
Otherwise, it will behave incorrectly if enabled dynamically. Signed-off-by: Samuel Just <sjust@redhat.com>
Only implemented for rocksdb for now. Signed-off-by: Samuel Just <sjust@redhat.com>
…Throttle This will make it easier to have a single place to emit trace information. Signed-off-by: Samuel Just <sjust@redhat.com>
This patch adds per-io bluestore specific tracepoints detailing the throttle state at queue time as well as state latencies during execution. Additionally, bluestore_throttle_trace_rate will limit the rate at which ios have tracepoints emitted. Signed-off-by: Samuel Just <sjust@redhat.com>
…ence/size Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
athanatos
force-pushed
the
sjust/wip-fio-trace
branch
from
ae1eead
to
07c8c00
Compare
|
Test run: http://pulpito.ceph.com/sjust-2019-09-29_21:12:10-rados-wip-sjust-testing2-distro-basic-smithi/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds bluestore tracepoints for recording a variety of initial conditions for sampled ios including:
Also updates the fio_ceph_objectstore backend to optionally emit json formatted perf counters to a file as well as support for running multiple jobs and varying the throttle limits during a run.
The intention is that this functionality as well ceph/cbt#190 will enable somewhat quicker iteration on modifications to bluestore intended to improve throttle behavior or IO latency variability.