rgw: make sure modelines are correct for all files #29742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbodley
reviewed
Aug 19, 2019
| @@ -1,5 +1,5 @@ | |||
| // -*- mode:C++; tab-width:8; c-basic-offset:2; indent-tabs-mode:t -*- | |||
| // vim: ts=8 sw=2 smarttab | |||
| // vim: ts=8 sw=2 smarttab ft=cpp | |||
There was a problem hiding this comment.
these modelines came straight from https://github.com/ceph/ceph/blob/master/CodingStyle#L76-L82 so i'd prefer not to change them; why can't vim detect the filetype from the .cc extension?
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
cbodley
reviewed
Aug 20, 2019
| @@ -79,7 +79,7 @@ by section. | |||
| header is: | |||
|
|
|||
| // -*- mode:C++; tab-width:8; c-basic-offset:2; indent-tabs-mode:t -*- | |||
| // vim: ts=8 sw=2 smarttab | |||
| // vim: ts=8 sw=2 smarttab ft=cpp | |||
There was a problem hiding this comment.
@liewegas any objection to this change in CodingStyle? the intent is to identify .h files as c++ instead of c, to match the 'mode:C++' for emacs
There was a problem hiding this comment.
Sounds like a great idea to me!
liewegas
changed the title
cbodley
approved these changes
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Gryniewicz dang@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test docsjenkins render docs