-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools/rbd-ggate: close log before running postfork #30010
Conversation
@wjwithagen I wonder isn't a350c80 fixed the similar issue in rbd-nbd? Could you please try? (Right now I don't have an evironment with freshly built ceph to try it myself). |
Also, don't you want to backport the fix to the stable releases? Then it would be good to create a tracker ticket for this issue. |
I think this needs to go for backport, once I has the correct fix. Usually I first fix master, and see what comes of it. Sometimes it is a totally different problem from what I first thought. |
I tried looking in what |
@trociny |
@wjwithagen Excellent! So, could you please create a tracker ticket, squash your commits into one and add 'Fixes: ...' to the commit log message? |
5094e52
to
02a6034
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: s/fixes:/Fixes:/
otherwise LGTM
Otherwise the assert in Log:open() will trigger since all data is kept during the fork and also the `is_started` flag Fixes: https://tracker.ceph.com/issues/41592 Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
02a6034
to
21bdd4c
Compare
Otherwise the assert in Log:open() will trigger since
all data is kept during the fork and also the
is_started
flagFixes: https://tracker.ceph.com/issues/41592
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard backend
jenkins test docs
jenkins render docs