Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/rbd-ggate: close log before running postfork #30010

Merged
merged 1 commit into from
Sep 2, 2019

Conversation

wjwithagen
Copy link
Contributor

@wjwithagen wjwithagen commented Aug 29, 2019

Otherwise the assert in Log:open() will trigger since
all data is kept during the fork and also the is_started flag

Fixes: https://tracker.ceph.com/issues/41592

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs

@wjwithagen wjwithagen added bug-fix FreeBSD Modifications specific for (only) FreeBSD tools labels Aug 29, 2019
@trociny
Copy link
Contributor

trociny commented Aug 29, 2019

@wjwithagen I wonder isn't a350c80 fixed the similar issue in rbd-nbd? Could you please try? (Right now I don't have an evironment with freshly built ceph to try it myself).

@trociny
Copy link
Contributor

trociny commented Aug 29, 2019

Also, don't you want to backport the fix to the stable releases? Then it would be good to create a tracker ticket for this issue.

@wjwithagen
Copy link
Contributor Author

Also, don't you want to backport the fix to the stable releases? Then it would be good to create a tracker ticket for this issue.

I think this needs to go for backport, once I has the correct fix.

Usually I first fix master, and see what comes of it. Sometimes it is a totally different problem from what I first thought.
If it then requires backporting, I make a tracker, and ask for back-ports.
I'm rather clumsy at creating back-ports, so unless I have to, I avoid them.
I also cheat, because I can add patches to the FreeBSD ports (and my jenkins tests) , in case they did not (yet) make it in the Ceph tree.

@wjwithagen
Copy link
Contributor Author

@wjwithagen I wonder isn't a350c80 fixed the similar issue in rbd-nbd? Could you please try? (Right now I don't have an evironment with freshly built ceph to try it myself).

I tried looking in what nbd-stuff did, but overlooked the more interresting stuff.
Will try also this aproach.

@dillaman dillaman added the rbd label Aug 29, 2019
@wjwithagen
Copy link
Contributor Author

@trociny
The rbd-ndb example works....
I'll redo this PR that way.

@trociny
Copy link
Contributor

trociny commented Aug 30, 2019

@wjwithagen Excellent! So, could you please create a tracker ticket, squash your commits into one and add 'Fixes: ...' to the commit log message?

@wjwithagen
Copy link
Contributor Author

Copy link
Contributor

@trociny trociny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/fixes:/Fixes:/

otherwise LGTM

Otherwise the assert in Log:open() will trigger since
all data is kept during the fork and also the `is_started` flag

Fixes: https://tracker.ceph.com/issues/41592
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
@trociny trociny merged commit 4a1ab10 into ceph:master Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix FreeBSD Modifications specific for (only) FreeBSD rbd tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants