Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Support iSCSI target-level CHAP auth #30011

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

ricardoasmarques
Copy link
Contributor

@ricardoasmarques ricardoasmarques commented Aug 29, 2019

This PR adds support for iSCSI target-level CHAP authentication.

Requires ceph-iscsi config v11 introduced on PR ceph/ceph-iscsi#133 (Merged).

Fixes: https://tracker.ceph.com/issues/41576

Signed-off-by: Ricardo Marques rimarques@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs

@ricardoasmarques ricardoasmarques requested a review from a team as a code owner August 29, 2019 14:36
@ricardoasmarques ricardoasmarques force-pushed the target-level-auth branch 2 times, most recently from e9afa0c to 86a1ecc Compare August 30, 2019 08:21
@ricardoasmarques
Copy link
Contributor Author

According to ceph/ceph-iscsi#133 (comment) this PR should be adapted to NOT allow mixing TPG/target auth with ACL auth.

@ricardoasmarques
Copy link
Contributor Author

This PR was updated to NOT allow mixing TPG/target auth with ACL auth.

@ricardoasmarques
Copy link
Contributor Author

jenkins retest this please

@ricardoasmarques
Copy link
Contributor Author

FYI ceph/ceph-iscsi#133 has been merged.

@ricardoasmarques ricardoasmarques changed the title [After ceph-iscsi#133] mgr/dashboard: Support iSCSI target-level CHAP auth mgr/dashboard: Support iSCSI target-level CHAP auth Sep 25, 2019
Requires `ceph-iscsi` config v11

Fixes: https://tracker.ceph.com/issues/41576

Signed-off-by: Ricardo Marques <rimarques@suse.com>
@ricardoasmarques
Copy link
Contributor Author

jenkins test make check arm64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants