Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: Set RO as the default access_type for RGW NFS exports #30111

Merged
merged 1 commit into from
Sep 10, 2019
Merged

mgr/dashboard: Set RO as the default access_type for RGW NFS exports #30111

merged 1 commit into from
Sep 10, 2019

Conversation

tspmelo
Copy link
Contributor

@tspmelo tspmelo commented Sep 3, 2019 •
edited by votdev
Loading

It will also show an warning if the user selects RW access_type.

Fixes: https://tracker.ceph.com/issues/40186

Signed-off-by: Tiago Melo tmelo@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs

@tspmelo tspmelo requested a review from a team as a code owner September 3, 2019 15:36
@tspmelo tspmelo requested a review from LenzGr September 3, 2019 15:37
mgr/dashboard: Set RO as the default access_type for RGW NFS exports
b40b510 
It will also show an warning if the user selects RW access_type.

Fixes: https://tracker.ceph.com/issues/40186

Signed-off-by: Tiago Melo <tmelo@suse.com>
LenzGr
LenzGr approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@LenzGr LenzGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tspmelo tspmelo requested a review from a team September 5, 2019 10:01
@tspmelo
Copy link
Contributor Author

tspmelo commented Sep 5, 2019

jenkins test docs

1 similar comment
@tspmelo
Copy link
Contributor Author

tspmelo commented Sep 5, 2019

jenkins test docs

@tspmelo
Copy link
Contributor Author

tspmelo commented Sep 5, 2019

jenkins test dashboard

1 similar comment
@tspmelo
Copy link
Contributor Author

tspmelo commented Sep 9, 2019

jenkins test dashboard

ricardoasmarques
ricardoasmarques approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@ricardoasmarques ricardoasmarques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LenzGr LenzGr merged commit 45b017f into ceph:master Sep 10, 2019
@tspmelo tspmelo deleted the wip-nfs-read branch September 10, 2019 10:36
@tspmelo tspmelo mentioned this pull request Sep 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LenzGr LenzGr LenzGr approved these changes

@ricardoasmarques ricardoasmarques ricardoasmarques approved these changes

Assignees
No one assigned
Labels
dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tspmelo @LenzGr @ricardoasmarques