Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: fix error when linking a bucket to a tenanted u… #30123

Merged
merged 1 commit into from
Sep 23, 2019
Merged

mgr/dashboard: fix error when linking a bucket to a tenanted u… #30123

merged 1 commit into from
Sep 23, 2019

Conversation

bk201
Copy link
Contributor

@bk201 bk201 commented Sep 4, 2019

  • Prefix bucket name with '/' when linking bucket to a tenanted user
  • Add qa tests

Fixes: https://tracker.ceph.com/issues/41611

Signed-off-by: Kiefer Chang kiefer.chang@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs

@bk201 bk201 requested a review from a team as a code owner September 4, 2019 03:48
@bk201
Copy link
Contributor Author

bk201 commented Sep 4, 2019

#29485 also fixes this issue on nautilus.

@bk201
Copy link
Contributor Author

bk201 commented Sep 18, 2019

jenkins test make check

alfonsomthd
alfonsomthd approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@alfonsomthd alfonsomthd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally: LGTM

@bk201
mgr/dashboard: fix error when linking a bucket to a tenanted user
7866c5f 
- Prefix bucket name with '/' when linking bucket to a tenanted user
- Add qa tests

Fixes: https://tracker.ceph.com/issues/41611

Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
@bk201 bk201 added the needs-qa label Sep 19, 2019
@alfonsomthd alfonsomthd mentioned this pull request Sep 20, 2019
Merged
3 tasks
@LenzGr LenzGr changed the title mgr/dashboard: fix error when linking a bucket to a tenanted user mgr/dashboard: fix error when linking a bucket to a tenanted u… Sep 23, 2019
@LenzGr LenzGr merged commit 35674ff into ceph:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@votdev votdev votdev approved these changes

@alfonsomthd alfonsomthd alfonsomthd approved these changes

Assignees
No one assigned
Labels
bug-fix dashboard needs-qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bk201 @votdev @alfonsomthd @LenzGr