cls/rbd: add snapshot limit UINT64_MAX test case #31350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenpan1012
force-pushed
the
rbd_testcase
branch
from
b5bfbed
to
1694167
Compare
dillaman
reviewed
Nov 4, 2019
src/test/cls_rbd/test_cls_rbd.cc
Outdated
| @@ -723,6 +723,10 @@ TEST_F(TestClsRbd, snapshot_limits) | |||
|
|
|||
| ASSERT_EQ(0, create_image(&ioctx, oid, 0, 22, RBD_FEATURE_LAYERING, oid, -1)); | |||
|
|
|||
| // if snapshot doesn't set limit, the limit is UINT64_MAX | |||
| ASSERT_EQ(0, snapshot_get_limit(&ioctx, oid, &limit)); | |||
| ASSERT_EQ(limit, UINT64_MAX); | |||
There was a problem hiding this comment.
Expectation should be listed first:
Suggested change
| ASSERT_EQ(limit, UINT64_MAX); | |
| ASSERT_EQ(UINT64_MAX, limit); |
There was a problem hiding this comment.
Thanks.
I will change later.
chenpan1012
force-pushed
the
rbd_testcase
branch
from
1694167
to
c4888dc
Compare
Signed-off-by: Chen Pan <chenpan@cmss.chinamobile.com>
|
jenkins test make check arm64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chen Pan chenpan@cmss.chinamobile.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox