ceph-daemon: add explicit pull at bootstrap start #31478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is less confusing for users since the pull can be slow and the uid/gid check is a weird thing to hang on for a long time. Signed-off-by: Sage Weil <sage@redhat.com>
sebastian-philipp
approved these changes
Nov 8, 2019
It occurs to me there might be cases where the user *doesn't* want to pull the latest image (e.g., because it is a partially disconnected enviroment, and they know the image is already in the local registry). Signed-off-by: Sage Weil <sage@redhat.com>
|
still lgtm |
liewegas
added a commit
that referenced
this pull request
Nov 8, 2019
* refs/pull/31478/head: ceph-daemon: add --skip-pull ceph-daemon: add explicit pull at bootstrap start Reviewed-by: Sebastian Wagner <swagner@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is less confusing for users since the pull can be slow and the
uid/gid check is a weird thing to hang on for a long time.
Signed-off-by: Sage Weil sage@redhat.com