mgr/dashboard: Process password complexity checks immediately #32032

votdev · 2019-12-05T14:39:18Z

Add api/user/validate_password endpoint to check if a password meets the password policy.
Add Angular async validator to check if the entered password meets the policy.

Fixes: https://tracker.ceph.com/issues/43088

Signed-off-by: Volker Theile vtheile@suse.com

Checklist

References tracker ticket
Updates documentation if necessary
Includes tests for new functionality or reproducer for bug

Show available Jenkins commands

jenkins retest this please
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard backend
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox

votdev · 2019-12-06T10:59:44Z

jenkins test make check

votdev · 2019-12-06T13:48:36Z

jenkins test dashboard

votdev · 2019-12-06T13:48:45Z

jenkins test make check

votdev · 2019-12-10T08:35:50Z

jenkins test make check arm64

src/pybind/mgr/dashboard/controllers/orchestrator.py

src/pybind/mgr/dashboard/frontend/src/app/core/auth/user-form/user-form.component.ts

src/pybind/mgr/dashboard/controllers/user.py

Devp00l

Nice improvements :) I left some suggestions, maybe you could address the one or the other before your vacation starts ;)

src/pybind/mgr/dashboard/controllers/user.py

src/pybind/mgr/dashboard/frontend/src/app/core/auth/user-form/user-form.component.ts

src/pybind/mgr/dashboard/frontend/src/app/shared/api/user.service.ts

src/pybind/mgr/dashboard/frontend/src/app/shared/services/password-policy.service.ts

votdev · 2019-12-11T13:08:01Z

jenkins test dashboard backend

votdev · 2019-12-11T13:08:12Z

jenkins test dashboard

Devp00l

LGTM :)

src/pybind/mgr/dashboard/controllers/user.py

tspmelo

lgtm

votdev · 2019-12-12T22:06:03Z

jenkins test dashboard

s0nea · 2019-12-19T08:52:34Z

jenkins test make check

bk201 · 2019-12-23T02:40:44Z

jenkins test dashboard

- Add 'api/user/validate_password' endpoint to check if a password meets the password policy. A new controller has to be added for 'api/user' which has NO security scope, otherwise it wouldn't be possible for users without USER privileges to call the endpoint. - Add Angular async validator to check if the entered password meets the policy. Fixes: https://tracker.ceph.com/issues/43088 Signed-off-by: Volker Theile <vtheile@suse.com>

1. Fix the test cases by using the 'assertJsonBody' method. The '_post' method doesn't return anything. That's why we need to use the 'assertJsonBody' method here instead of checking the fields directly. 2. Add the missing scope and permission definition of the 'validate_password' resource. Otherwise the resource is not restricted and 'test_validate_password_invalid_permissions' will fail. 3. Re-word error messages. Change 'cannot' to 'must not'. Signed-off-by: Tatjana Dehler <tdehler@suse.com>

* Remove scope and permission check from UserPasswordPolicy controller again, otherwise the Angular UI validator can't be executed for users without that privilege. * Remobe obsolete QA test. Signed-off-by: Volker Theile <vtheile@suse.com>

s0nea

The QA test run was successful: http://pulpito.ceph.com/tdehler-2020-01-07_15:16:41-rados:dashboard-wip-tdehler-testing-32032-32234-32461-distro-basic-smithi/

votdev · 2020-01-09T12:08:18Z

jenkins test dashboard backend

votdev · 2020-01-09T13:28:56Z

jenkins test dashboard

votdev · 2020-01-10T08:33:13Z

jenkins test dashboard

votdev · 2020-01-10T10:32:37Z

jenkins test dashboard backend

callithea · 2020-01-10T12:44:25Z

jenkins test dashboard backend

Test failure:

2020-01-10 12:12:12,856.856 INFO:__main__:Running ['./bin/ceph', 'log', 'Ended test tasks.mgr.dashboard.test_user.UserTest.test_pwd_expiration_date_update']
2020-01-10 12:12:13,441.441 INFO:__main__:Stopped test: test_pwd_expiration_date_update (tasks.mgr.dashboard.test_user.UserTest) in 11.87283s
2020-01-10 12:12:13,442.442 INFO:__main__:
2020-01-10 12:12:13,443.443 INFO:__main__:======================================================================
2020-01-10 12:12:13,443.443 INFO:__main__:ERROR: test_pwd_expiration_date_update (tasks.mgr.dashboard.test_user.UserTest)
2020-01-10 12:12:13,443.443 INFO:__main__:----------------------------------------------------------------------
2020-01-10 12:12:13,443.443 INFO:__main__:Traceback (most recent call last):
2020-01-10 12:12:13,444.444 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-dashboard-pr-backend/qa/tasks/mgr/dashboard/test_user.py", line 379, in test_pwd_expiration_date_update
2020-01-10 12:12:13,444.444 INFO:__main__:    self.login('user1', 'mypassword10#')
2020-01-10 12:12:13,444.444 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-dashboard-pr-backend/qa/tasks/mgr/dashboard/helper.py", line 87, in login
2020-01-10 12:12:13,444.444 INFO:__main__:    cls.logout()
2020-01-10 12:12:13,444.444 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-dashboard-pr-backend/qa/tasks/mgr/dashboard/helper.py", line 95, in logout
2020-01-10 12:12:13,445.445 INFO:__main__:    cls._post('/api/auth/logout')
2020-01-10 12:12:13,445.445 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-dashboard-pr-backend/qa/tasks/mgr/dashboard/helper.py", line 234, in _post
2020-01-10 12:12:13,445.445 INFO:__main__:    cls._request(url, 'POST', data, params)
2020-01-10 12:12:13,445.445 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-dashboard-pr-backend/qa/tasks/mgr/dashboard/helper.py", line 189, in _request
2020-01-10 12:12:13,445.445 INFO:__main__:    verify=False, headers=headers)
2020-01-10 12:12:13,446.446 INFO:__main__:  File "/tmp/tmp.YPHoMV6fOL/venv/local/lib/python2.7/site-packages/requests/sessions.py", line 572, in post
2020-01-10 12:12:13,446.446 INFO:__main__:    return self.request('POST', url, data=data, json=json, **kwargs)
2020-01-10 12:12:13,446.446 INFO:__main__:  File "/tmp/tmp.YPHoMV6fOL/venv/local/lib/python2.7/site-packages/requests/sessions.py", line 524, in request
2020-01-10 12:12:13,446.446 INFO:__main__:    resp = self.send(prep, **send_kwargs)
2020-01-10 12:12:13,446.446 INFO:__main__:  File "/tmp/tmp.YPHoMV6fOL/venv/local/lib/python2.7/site-packages/requests/sessions.py", line 637, in send
2020-01-10 12:12:13,446.446 INFO:__main__:    r = adapter.send(request, **kwargs)
2020-01-10 12:12:13,447.447 INFO:__main__:  File "/tmp/tmp.YPHoMV6fOL/venv/local/lib/python2.7/site-packages/requests/adapters.py", line 498, in send
2020-01-10 12:12:13,447.447 INFO:__main__:    raise ConnectionError(err, request=request)
2020-01-10 12:12:13,447.447 INFO:__main__:ConnectionError: ('Connection aborted.', error("(104, 'ECONNRESET')",))
2020-01-10 12:12:13,447.447 INFO:__main__:
2020-01-10 12:12:13,447.447 INFO:__main__:----------------------------------------------------------------------
2020-01-10 12:12:13,448.448 INFO:__main__:Ran 234 tests in 2329.236s
2020-01-10 12:12:13,448.448 INFO:__main__:
2020-01-10 12:12:13,448.448 INFO:__main__:FAILED (errors=1)
2020-01-10 12:12:13,448.448 INFO:__main__:
2020-01-10 12:12:13,449.449 INFO:__main__:======================================================================
2020-01-10 12:12:13,449.449 INFO:__main__:ERROR: test_pwd_expiration_date_update (tasks.mgr.dashboard.test_user.UserTest)
2020-01-10 12:12:13,449.449 INFO:__main__:----------------------------------------------------------------------
2020-01-10 12:12:13,449.449 INFO:__main__:Traceback (most recent call last):
2020-01-10 12:12:13,449.449 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-dashboard-pr-backend/qa/tasks/mgr/dashboard/test_user.py", line 379, in test_pwd_expiration_date_update
2020-01-10 12:12:13,450.450 INFO:__main__:    self.login('user1', 'mypassword10#')
2020-01-10 12:12:13,450.450 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-dashboard-pr-backend/qa/tasks/mgr/dashboard/helper.py", line 87, in login
2020-01-10 12:12:13,450.450 INFO:__main__:    cls.logout()
2020-01-10 12:12:13,450.450 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-dashboard-pr-backend/qa/tasks/mgr/dashboard/helper.py", line 95, in logout
2020-01-10 12:12:13,450.450 INFO:__main__:    cls._post('/api/auth/logout')
2020-01-10 12:12:13,451.451 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-dashboard-pr-backend/qa/tasks/mgr/dashboard/helper.py", line 234, in _post
2020-01-10 12:12:13,451.451 INFO:__main__:    cls._request(url, 'POST', data, params)
2020-01-10 12:12:13,451.451 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-dashboard-pr-backend/qa/tasks/mgr/dashboard/helper.py", line 189, in _request
2020-01-10 12:12:13,451.451 INFO:__main__:    verify=False, headers=headers)
2020-01-10 12:12:13,451.451 INFO:__main__:  File "/tmp/tmp.YPHoMV6fOL/venv/local/lib/python2.7/site-packages/requests/sessions.py", line 572, in post
2020-01-10 12:12:13,451.451 INFO:__main__:    return self.request('POST', url, data=data, json=json, **kwargs)
2020-01-10 12:12:13,452.452 INFO:__main__:  File "/tmp/tmp.YPHoMV6fOL/venv/local/lib/python2.7/site-packages/requests/sessions.py", line 524, in request
2020-01-10 12:12:13,452.452 INFO:__main__:    resp = self.send(prep, **send_kwargs)
2020-01-10 12:12:13,452.452 INFO:__main__:  File "/tmp/tmp.YPHoMV6fOL/venv/local/lib/python2.7/site-packages/requests/sessions.py", line 637, in send
2020-01-10 12:12:13,452.452 INFO:__main__:    r = adapter.send(request, **kwargs)
2020-01-10 12:12:13,452.452 INFO:__main__:  File "/tmp/tmp.YPHoMV6fOL/venv/local/lib/python2.7/site-packages/requests/adapters.py", line 498, in send
2020-01-10 12:12:13,452.452 INFO:__main__:    raise ConnectionError(err, request=request)
2020-01-10 12:12:13,453.453 INFO:__main__:ConnectionError: ('Connection aborted.', error("(104, 'ECONNRESET')",))

votdev · 2020-01-10T14:35:39Z

jenkins test dashboard backend

Test failure:

2020-01-10 12:12:12,856.856 INFO:__main__:Running ['./bin/ceph', 'log', 'Ended test tasks.mgr.dashboard.test_user.UserTest.test_pwd_expiration_date_update']
2020-01-10 12:12:13,441.441 INFO:__main__:Stopped test: test_pwd_expiration_date_update (tasks.mgr.dashboard.test_user.UserTest) in 11.87283s
2020-01-10 12:12:13,442.442 INFO:__main__:
2020-01-10 12:12:13,443.443 INFO:__main__:======================================================================
2020-01-10 12:12:13,443.443 INFO:__main__:ERROR: test_pwd_expiration_date_update (tasks.mgr.dashboard.test_user.UserTest)
2020-01-10 12:12:13,443.443 INFO:__main__:----------------------------------------------------------------------
2020-01-10 12:12:13,443.443 INFO:__main__:Traceback (most recent call last):
2020-01-10 12:12:13,444.444 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-dashboard-pr-backend/qa/tasks/mgr/dashboard/test_user.py", line 379, in test_pwd_expiration_date_update
2020-01-10 12:12:13,444.444 INFO:__main__:    self.login('user1', 'mypassword10#')
2020-01-10 12:12:13,444.444 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-dashboard-pr-backend/qa/tasks/mgr/dashboard/helper.py", line 87, in login
2020-01-10 12:12:13,444.444 INFO:__main__:    cls.logout()
2020-01-10 12:12:13,444.444 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-dashboard-pr-backend/qa/tasks/mgr/dashboard/helper.py", line 95, in logout
2020-01-10 12:12:13,445.445 INFO:__main__:    cls._post('/api/auth/logout')
2020-01-10 12:12:13,445.445 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-dashboard-pr-backend/qa/tasks/mgr/dashboard/helper.py", line 234, in _post
2020-01-10 12:12:13,445.445 INFO:__main__:    cls._request(url, 'POST', data, params)
2020-01-10 12:12:13,445.445 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-dashboard-pr-backend/qa/tasks/mgr/dashboard/helper.py", line 189, in _request
2020-01-10 12:12:13,445.445 INFO:__main__:    verify=False, headers=headers)
2020-01-10 12:12:13,446.446 INFO:__main__:  File "/tmp/tmp.YPHoMV6fOL/venv/local/lib/python2.7/site-packages/requests/sessions.py", line 572, in post
2020-01-10 12:12:13,446.446 INFO:__main__:    return self.request('POST', url, data=data, json=json, **kwargs)
2020-01-10 12:12:13,446.446 INFO:__main__:  File "/tmp/tmp.YPHoMV6fOL/venv/local/lib/python2.7/site-packages/requests/sessions.py", line 524, in request
2020-01-10 12:12:13,446.446 INFO:__main__:    resp = self.send(prep, **send_kwargs)
2020-01-10 12:12:13,446.446 INFO:__main__:  File "/tmp/tmp.YPHoMV6fOL/venv/local/lib/python2.7/site-packages/requests/sessions.py", line 637, in send
2020-01-10 12:12:13,446.446 INFO:__main__:    r = adapter.send(request, **kwargs)
2020-01-10 12:12:13,447.447 INFO:__main__:  File "/tmp/tmp.YPHoMV6fOL/venv/local/lib/python2.7/site-packages/requests/adapters.py", line 498, in send
2020-01-10 12:12:13,447.447 INFO:__main__:    raise ConnectionError(err, request=request)
2020-01-10 12:12:13,447.447 INFO:__main__:ConnectionError: ('Connection aborted.', error("(104, 'ECONNRESET')",))
2020-01-10 12:12:13,447.447 INFO:__main__:
2020-01-10 12:12:13,447.447 INFO:__main__:----------------------------------------------------------------------
2020-01-10 12:12:13,448.448 INFO:__main__:Ran 234 tests in 2329.236s
2020-01-10 12:12:13,448.448 INFO:__main__:
2020-01-10 12:12:13,448.448 INFO:__main__:FAILED (errors=1)
2020-01-10 12:12:13,448.448 INFO:__main__:
2020-01-10 12:12:13,449.449 INFO:__main__:======================================================================
2020-01-10 12:12:13,449.449 INFO:__main__:ERROR: test_pwd_expiration_date_update (tasks.mgr.dashboard.test_user.UserTest)
2020-01-10 12:12:13,449.449 INFO:__main__:----------------------------------------------------------------------
2020-01-10 12:12:13,449.449 INFO:__main__:Traceback (most recent call last):
2020-01-10 12:12:13,449.449 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-dashboard-pr-backend/qa/tasks/mgr/dashboard/test_user.py", line 379, in test_pwd_expiration_date_update
2020-01-10 12:12:13,450.450 INFO:__main__:    self.login('user1', 'mypassword10#')
2020-01-10 12:12:13,450.450 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-dashboard-pr-backend/qa/tasks/mgr/dashboard/helper.py", line 87, in login
2020-01-10 12:12:13,450.450 INFO:__main__:    cls.logout()
2020-01-10 12:12:13,450.450 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-dashboard-pr-backend/qa/tasks/mgr/dashboard/helper.py", line 95, in logout
2020-01-10 12:12:13,450.450 INFO:__main__:    cls._post('/api/auth/logout')
2020-01-10 12:12:13,451.451 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-dashboard-pr-backend/qa/tasks/mgr/dashboard/helper.py", line 234, in _post
2020-01-10 12:12:13,451.451 INFO:__main__:    cls._request(url, 'POST', data, params)
2020-01-10 12:12:13,451.451 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-dashboard-pr-backend/qa/tasks/mgr/dashboard/helper.py", line 189, in _request
2020-01-10 12:12:13,451.451 INFO:__main__:    verify=False, headers=headers)
2020-01-10 12:12:13,451.451 INFO:__main__:  File "/tmp/tmp.YPHoMV6fOL/venv/local/lib/python2.7/site-packages/requests/sessions.py", line 572, in post
2020-01-10 12:12:13,451.451 INFO:__main__:    return self.request('POST', url, data=data, json=json, **kwargs)
2020-01-10 12:12:13,452.452 INFO:__main__:  File "/tmp/tmp.YPHoMV6fOL/venv/local/lib/python2.7/site-packages/requests/sessions.py", line 524, in request
2020-01-10 12:12:13,452.452 INFO:__main__:    resp = self.send(prep, **send_kwargs)
2020-01-10 12:12:13,452.452 INFO:__main__:  File "/tmp/tmp.YPHoMV6fOL/venv/local/lib/python2.7/site-packages/requests/sessions.py", line 637, in send
2020-01-10 12:12:13,452.452 INFO:__main__:    r = adapter.send(request, **kwargs)
2020-01-10 12:12:13,452.452 INFO:__main__:  File "/tmp/tmp.YPHoMV6fOL/venv/local/lib/python2.7/site-packages/requests/adapters.py", line 498, in send
2020-01-10 12:12:13,452.452 INFO:__main__:    raise ConnectionError(err, request=request)
2020-01-10 12:12:13,453.453 INFO:__main__:ConnectionError: ('Connection aborted.', error("(104, 'ECONNRESET')",))

Can not reproduce it on my local machine and the error does not look related to this PR, so i'll trigger another run.

votdev · 2020-01-10T14:35:50Z

jenkins test dashboard backend

callithea · 2020-01-10T14:41:49Z

Can not reproduce it on my local machine and the error does not look related to this PR, so i'll trigger another run.

Thanks for the update!

votdev · 2020-01-13T09:23:26Z

jenkins test dashboard backend

votdev added cleanup dashboard labels Dec 5, 2019

votdev force-pushed the issue_43088_passwd_async_validator branch 4 times, most recently from 8c05874 to bb817a4 Compare December 6, 2019 09:45

votdev force-pushed the issue_43088_passwd_async_validator branch from bb817a4 to 096d19f Compare December 6, 2019 11:15

votdev force-pushed the issue_43088_passwd_async_validator branch 3 times, most recently from de65b6c to ba2b46d Compare December 9, 2019 13:02

votdev marked this pull request as ready for review December 9, 2019 14:22

votdev requested a review from a team as a code owner December 9, 2019 14:22

tspmelo suggested changes Dec 10, 2019

View reviewed changes

src/pybind/mgr/dashboard/controllers/orchestrator.py Outdated Show resolved Hide resolved

src/pybind/mgr/dashboard/frontend/src/app/core/auth/user-form/user-form.component.ts Show resolved Hide resolved

src/pybind/mgr/dashboard/controllers/user.py Show resolved Hide resolved

Devp00l reviewed Dec 10, 2019

View reviewed changes

votdev force-pushed the issue_43088_passwd_async_validator branch from ba2b46d to ba3f46b Compare December 11, 2019 10:41

LenzGr requested a review from tspmelo December 11, 2019 10:53

Devp00l approved these changes Dec 11, 2019

View reviewed changes

tspmelo suggested changes Dec 11, 2019

View reviewed changes

src/pybind/mgr/dashboard/controllers/user.py Outdated Show resolved Hide resolved

src/pybind/mgr/dashboard/controllers/user.py Outdated Show resolved Hide resolved

votdev force-pushed the issue_43088_passwd_async_validator branch from ba3f46b to 979a63a Compare December 12, 2019 06:49

votdev requested a review from tspmelo December 12, 2019 07:48

votdev force-pushed the issue_43088_passwd_async_validator branch 2 times, most recently from 57ff167 to 1b6c539 Compare December 12, 2019 11:40

tspmelo approved these changes Dec 12, 2019

View reviewed changes

s0nea removed the needs-rebase label Dec 16, 2019

s0nea force-pushed the issue_43088_passwd_async_validator branch 2 times, most recently from 8969faf to f3ca3bf Compare December 18, 2019 13:27

s0nea force-pushed the issue_43088_passwd_async_validator branch from f3ca3bf to d29eb5a Compare December 20, 2019 14:33

votdev and others added 2 commits January 2, 2020 10:49

votdev force-pushed the issue_43088_passwd_async_validator branch from d29eb5a to 48de3dc Compare January 2, 2020 09:58

mgr/dashboard: Various fixes

bf567f4

* Remove scope and permission check from UserPasswordPolicy controller again, otherwise the Angular UI validator can't be executed for users without that privilege. * Remobe obsolete QA test. Signed-off-by: Volker Theile <vtheile@suse.com>

votdev force-pushed the issue_43088_passwd_async_validator branch from 48de3dc to bf567f4 Compare January 2, 2020 10:13

s0nea approved these changes Jan 7, 2020

View reviewed changes

s0nea removed needs-qa wip-tdehler-testing labels Jan 7, 2020

votdev mentioned this pull request Jan 8, 2020

mgr/dashboard: Make password policy check configurable #32546

Merged

3 tasks

ceph deleted a comment from callithea Jan 9, 2020

votdev added the ready-to-merge label Jan 13, 2020

callithea merged commit f22247f into ceph:master Jan 14, 2020

votdev deleted the issue_43088_passwd_async_validator branch January 14, 2020 10:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mgr/dashboard: Process password complexity checks immediately #32032

mgr/dashboard: Process password complexity checks immediately #32032

votdev commented Dec 5, 2019 •

edited

Loading

votdev commented Dec 6, 2019

votdev commented Dec 6, 2019

votdev commented Dec 6, 2019

votdev commented Dec 10, 2019

Devp00l left a comment

votdev commented Dec 11, 2019

votdev commented Dec 11, 2019

Devp00l left a comment

tspmelo left a comment

votdev commented Dec 12, 2019

s0nea commented Dec 19, 2019

bk201 commented Dec 23, 2019

s0nea left a comment

votdev commented Jan 9, 2020

votdev commented Jan 9, 2020

votdev commented Jan 10, 2020

votdev commented Jan 10, 2020

callithea commented Jan 10, 2020

votdev commented Jan 10, 2020

votdev commented Jan 10, 2020

callithea commented Jan 10, 2020

votdev commented Jan 13, 2020

mgr/dashboard: Process password complexity checks immediately #32032

mgr/dashboard: Process password complexity checks immediately #32032

Conversation

votdev commented Dec 5, 2019 • edited Loading

Checklist

votdev commented Dec 6, 2019

votdev commented Dec 6, 2019

votdev commented Dec 6, 2019

votdev commented Dec 10, 2019

Devp00l left a comment

Choose a reason for hiding this comment

votdev commented Dec 11, 2019

votdev commented Dec 11, 2019

Devp00l left a comment

Choose a reason for hiding this comment

tspmelo left a comment

Choose a reason for hiding this comment

votdev commented Dec 12, 2019

s0nea commented Dec 19, 2019

bk201 commented Dec 23, 2019

s0nea left a comment

Choose a reason for hiding this comment

votdev commented Jan 9, 2020

votdev commented Jan 9, 2020

votdev commented Jan 10, 2020

votdev commented Jan 10, 2020

callithea commented Jan 10, 2020

votdev commented Jan 10, 2020

votdev commented Jan 10, 2020

callithea commented Jan 10, 2020

votdev commented Jan 13, 2020

votdev commented Dec 5, 2019 •

edited

Loading