nautilus: os/bluestore: default bluestore_block_size 1T -> 100G #32283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes vstart *way* faster. This option is only really relevant for dev test environments. We bumped it up back in dbdd1d9 from 10G just to make ENOSPC less common in dev/test. Let's see if 100G is a better balance. Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 57890fc) Conflicts: src/common/options.cc: we did not cherry-pick dbdd1d9 to nautilus, so we'll directly go from 10G->100G
|
Not sure this matters.. the reason to go from 10G -> 100G was to make ENOSPC less common for a developer using vstart. And we aren't usually developing on the nautilus branch. |
The cram test 15f360d#diff-bce7896e1ecd14da7871a0509c3fcb9d fails in nautilus without this, maybe we can increase it just for that test or not run this test in nautilus? |
|
Ah, ok. It's fine to merge this then, generally harmless! |
liewegas
approved these changes
Dec 16, 2019
ifed01
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/42913
This makes vstart way faster. This option is only really relevant
for dev test environments. We bumped it up back in dbdd1d9
from 10G just to make ENOSPC less common in dev/test. Let's see if 100G
is a better balance.
Signed-off-by: Sage Weil sage@redhat.com
(cherry picked from commit 57890fc)
Conflicts:
src/common/options.cc: we did not cherry-pick
dbdd1d9 to nautilus, so we'll directly
go from 10G->100G