mgr/cephadm: fix type of timeout options #32316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timeout options need to be in `secs` type. Then the input values will be checked and converted into integer before use. Fixes: https://tracker.ceph.com/issues/43363 Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
|
jenkins test make check |
sebastian-philipp
approved these changes
Dec 18, 2019
The option needs to be in `secs` type to enable input checking and type casting. Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
The option setting loop in config_notify raises an exception if smtp_host option is not configured. Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
Fixed. |
|
jenkins test make check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeout options need to be in
secstype. Then the input valueswill be checked and converted into integer before use.
Fixes: https://tracker.ceph.com/issues/43363
Signed-off-by: Kiefer Chang kiefer.chang@suse.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox