mon: Don't put session during feature change #32365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batrick
approved these changes
Dec 20, 2019
The session gets put as result of the set_session call in the next block. Fixes: https://tracker.ceph.com/issues/38345 Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
badone
force-pushed
the
wip-feature-change-put-off-by-one-error
branch
from
4421372
to
8f23f2c
Compare
tchaikov
previously requested changes
Jan 6, 2020
|
@badone ? |
|
From memory the act of calling set_session replaces the old session and there is an implicit put when ~intrusive_ptr() is called. I tested this with refcounted object debugging and the count is correct with this patch whereas we call put one too many times without. |
liewegas
approved these changes
Jan 22, 2020
liewegas
added a commit
that referenced
this pull request
Jan 28, 2020
* refs/pull/32365/head: mon: Don't put session during feature change Reviewed-by: Sage Weil <sage@redhat.com> Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
This was referenced Feb 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The session gets put as result of the set_session call in the next
block.
Fixes: https://tracker.ceph.com/issues/38345
Signed-off-by: Brad Hubbard bhubbard@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox