src/dmclock: bring in fixes for indirect_intrusive_heap #32380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samuel Just <sjust@redhat.com>
|
Above run filtered for centos 8 -- other failures appear unrelated/similar to master runs. |
|
ceph/dmclock#75 needs to be merged first. |
jdurgin
reviewed
Dec 20, 2019
src/CMakeLists.txt
Outdated
| @@ -108,6 +108,12 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL GNU) | |||
| endif() | |||
| endif(CMAKE_CXX_COMPILER_ID STREQUAL GNU) | |||
|
|
|||
| CHECK_C_COMPILER_FLAG("-D_GLIBCXX_ASSERTIONS" HAS_GLIBC_DEBUG) | |||
There was a problem hiding this comment.
may want to restrict this to debug builds
jdurgin
approved these changes
Dec 20, 2019
athanatos
force-pushed
the
sjust/wip-dmclock-fix
branch
from
9337acd
to
7b2cba6
Compare
athanatos
changed the title
|
@jdurgin Turns out there are 3 unittests that don't pass with GLIBCXX_ASSERTIONS enabled. I've dropped that commit for now and will fix those in a separate PR. |
|
sounds good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.