mgr/cephadm: init attrs created by settattr() #32957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-philipp
approved these changes
Jan 29, 2020
src/pybind/mgr/cephadm/module.py
Outdated
| @@ -327,6 +327,15 @@ def __init__(self, *args, **kwargs): | |||
| super(CephadmOrchestrator, self).__init__(*args, **kwargs) | |||
| self._cluster_fsid = self.get('mon_map')['fsid'] | |||
|
|
|||
| # for mypy which does not run the code | |||
There was a problem hiding this comment.
Actually, I'd do this before calling super(), as I really want to avoid this to collide with
ceph/src/pybind/mgr/cephadm/module.py
Line 674 in c1b88a9
OTOH, lgtm.
tchaikov
force-pushed
the
wip-mgr-cephadm
branch
from
5fc15d4
to
e554544
Compare
to address the test falure caused by mypy: ``` mypy run-test: commands[0] | mypy --config-file=../../mypy.ini ansible/module.py cephadm/module.py mgr_module.py mgr_util.py orchestrator.py orchestrator_cli/module.py rook/module.py test_orchestrator/module.py cephadm/module.py: note: In member "_check_for_strays" of class "CephadmOrchestrator": cephadm/module.py:596: error: "CephadmOrchestrator" has no attribute "warn_on_stray_hosts" cephadm/module.py:596: error: "CephadmOrchestrator" has no attribute "warn_on_stray_services" cephadm/module.py:599: error: "CephadmOrchestrator" has no attribute "warn_on_stray_services" Found 3 errors in 1 file (checked 8 source files) ``` see also python/mypy#5719 Signed-off-by: Kefu Chai <kchai@redhat.com>
since these options are already initialized in the constructor, there is no need to ignore their types when checking those lines using mypy Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-mgr-cephadm
branch
from
e554544
to
e39f34f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox