mgr/pg_autoscaler: treat target ratios as weights #33035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
reviewed
Feb 3, 2020
liewegas
reviewed
Feb 3, 2020
liewegas
approved these changes
Feb 3, 2020
jdurgin
force-pushed
the
wip-target-ratio
branch
from
f2690b1
to
13eef77
Compare
tchaikov
force-pushed
the
wip-target-ratio
branch
from
13eef77
to
48ec3fd
Compare
Normalize across pools so that it's simpler to use - this way you don't have to adjust every other pool when you add one. Handle pools with target_bytes by taking their capacity off the top, and dividing the rest into the pools with a target_ratio. If both target bytes and ratio are specified, ignore bytes. This matches the docs and makes accounting simpler. Fixes: https://tracker.ceph.com/issues/43947 Signed-off-by: Josh Durgin <jdurgin@redhat.com>
Also check for pg_num_target being set correctly, rather than pg_num, so the test doesn't depend on merging/splitting speed. Signed-off-by: Josh Durgin <jdurgin@redhat.com>
Since the ratios are normalized, they cannot exceed 1.0 or overcommit combined with target_bytes. Signed-off-by: Josh Durgin <jdurgin@redhat.com>
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
Reset the progress each time we make an adjustment, and track progress from that initial state to that new target. Previously we were also using the wrong target: the current pg_num_target, not the new value (pg_num_final) that we set. Look up the pool by name, not id, in _maybe_adjust(), since that is how it is retrieved by osdmap.get_pools_by_name(). Dedupe some logic into PgAdjustmentProgress to simplify things. Signed-off-by: Josh Durgin <jdurgin@redhat.com>
Keep it as an int so we don't have to cast back and forth. Signed-off-by: Josh Durgin <jdurgin@redhat.com>
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
tchaikov
force-pushed
the
wip-target-ratio
branch
from
48ec3fd
to
bee99cc
Compare
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
tchaikov
force-pushed
the
wip-target-ratio
branch
from
bee99cc
to
fff3b70
Compare
|
changelog
|
obnoxxx
added a commit
to obnoxxx/ocs-operator
that referenced
this pull request
Feb 28, 2020
Currently, due to a floating point imprecision in ceph, we get a "HEALTH_WARN 1 subtrees have overcommitted pool target_size_ratio" after deplyoing with the TargetSizeRatio of .5 (0.5 + 0.5 > 1.0..). This will be fixed in future Ceph versions (ceph/ceph#33035). In order to avoid the warning until we have the updated Ceph, this patch lowers the ratio to 0.49. https://bugzilla.redhat.com/show_bug.cgi?id=1807950 Signed-off-by: Michael Adam <obnox@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests quickly ran into bugs in the progress handling that crashed the module, so those are fixed too.
https://tracker.ceph.com/issues/43947
Only the first 7 commits (in --topo-order, not as shown by github) are relevant for a backport - the rest are master-specific.