cls/queue: add unit tests #33218
Merged
cls/queue: add unit tests #33218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvalif
force-pushed
the
add_cls_queue_ut
branch
from
905ab62
to
d81dd6b
Compare
yuvalif
force-pushed
the
add_cls_queue_ut
branch
from
45a417c
to
282fc07
Compare
|
looks good to me. |
thanks. could you please approve? |
|
#33372 - referencing this PR here, the second commit needs to be reviewed before it goes in. |
pritha-srivastava
approved these changes
Feb 19, 2020
Signed-off-by: Yuval Lifshitz <yuvalif@yahoo.com>
Signed-off-by: Yuval Lifshitz <yuvalif@yahoo.com>
yuvalif
force-pushed
the
add_cls_queue_ut
branch
from
282fc07
to
1169cd0
Compare
@pritha-srivastava since your PR is merged, I removed the commit, rebased and pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuval Lifshitz yuvalif@yahoo.com
2 code issue was found by UT and fixed in the 2 commits of this review