Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qa/vstart_runner.py: make run()'s interface same as teuthology's run #33263

Merged
merged 1 commit into from
Feb 25, 2020
Merged

qa/vstart_runner.py: make run()'s interface same as teuthology's run #33263

merged 1 commit into from
Feb 25, 2020

Conversation

rishabh-d-dave
Copy link
Contributor

Arguments accepted by method run in teuthology should be exactly same as
that of arguments accepted by vstart_runner.py's method run to prevent
test failure with teuthology due to silly argument mismatch.
Teuthology's entry method run expects **kwargs, therefore so should
vstart_runner.py's run.

Fixes: https://tracker.ceph.com/issues/44117

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Feb 13, 2020 •
edited
Loading

vstart_runner.LocalRemote.run's interface aligned with the method here - https://github.com/ceph/teuthology/blob/master/teuthology/orchestra/remote.py#L188 and https://github.com/ceph/teuthology/blob/master/teuthology/orchestra/run.py#L366.

tchaikov
tchaikov reviewed Feb 13, 2020
View reviewed changes
qa/tasks/vstart_runner.py Outdated Show resolved Hide resolved
@tchaikov tchaikov added the tests label Feb 13, 2020
@tchaikov
Copy link
Contributor

jenkins test dashboard

@tchaikov
Copy link
Contributor

jenkins test dashboard backend

tchaikov
tchaikov approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just two nits.

qa/tasks/vstart_runner.py Outdated Show resolved Hide resolved
@rishabh-d-dave
qa/vstart_runner.py: make run()'s interface same as teuthology's run
061d972 
Arguments accepted by method run in teuthology should be exactly same as
that of arguments accepted by vstart_runner.py's method run to prevent
test failure with teuthology due to silly argument mismatch.
Teuthology's entry method run expects **kwargs, therefore so should
vstart_runner.py's run.

Fixes: https://tracker.ceph.com/issues/44117
Signed-off-by: Rishabh Dave <ridave@redhat.com>
@batrick batrick merged commit e5841ce into ceph:master Feb 25, 2020
@rishabh-d-dave rishabh-d-dave deleted the fs-vstart_runner-run-interface branch September 9, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaikov tchaikov tchaikov approved these changes

@batrick batrick batrick approved these changes

Assignees
No one assigned
Labels
bug-fix cephfs Ceph File System needs-review tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rishabh-d-dave @tchaikov @batrick