-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
librbd: Improved support for balanced and localized reads #33493
Conversation
Can you also create a new teuthology test case where you enable this feature (perhaps in just balance mode for simplicity) during an RBD xfstest/fsx test concurrent w/ the OSD thrasher; and set |
thanks @dillaman , I add read balance mode test case in test_librbd. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to modify ImageCtx::get_read_flags
to return the current setting of ImageCtx::read_flags
if not zero, else follow current logic for parent/snapshot read flags.
Fixes: https://tracker.ceph.com/issues/43793 Signed-off-by: Zheng Yin <zhengyin@cmss.chinamobile.com>
Sorry, I confused op_flags and read_flags, thanks. |
Signed-off-by: Zheng Yin <zhengyin@cmss.chinamobile.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm -- thx
jenkins test make check |
Fixes: https://tracker.ceph.com/issues/43793
Signed-off-by: Zheng Yin zhengyin@cmss.chinamobile.com
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard backend
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox