Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: Improved support for balanced and localized reads #33493

Merged
merged 2 commits into from
Feb 27, 2020

Conversation

zhengchengyao
Copy link
Contributor

Fixes: https://tracker.ceph.com/issues/43793
Signed-off-by: Zheng Yin zhengyin@cmss.chinamobile.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

doc/rbd/rbd-config-ref.rst Outdated Show resolved Hide resolved
src/librbd/io/CopyupRequest.cc Outdated Show resolved Hide resolved
src/librbd/ImageCtx.cc Outdated Show resolved Hide resolved
@dillaman
Copy link

Can you also create a new teuthology test case where you enable this feature (perhaps in just balance mode for simplicity) during an RBD xfstest/fsx test concurrent w/ the OSD thrasher; and set ceph osd require-osd-release octopus?

@zhengchengyao
Copy link
Contributor Author

thanks @dillaman , I add read balance mode test case in test_librbd.

Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to modify ImageCtx::get_read_flags to return the current setting of ImageCtx::read_flags if not zero, else follow current logic for parent/snapshot read flags.

src/librbd/io/CopyupRequest.cc Outdated Show resolved Hide resolved
src/librbd/io/ObjectRequest.cc Outdated Show resolved Hide resolved
src/librbd/io/ObjectRequest.cc Outdated Show resolved Hide resolved
src/test/librbd/test_librbd.cc Show resolved Hide resolved
src/librbd/ImageCtx.h Outdated Show resolved Hide resolved
Fixes: https://tracker.ceph.com/issues/43793
Signed-off-by: Zheng Yin <zhengyin@cmss.chinamobile.com>
@zhengchengyao
Copy link
Contributor Author

Sorry, I confused op_flags and read_flags, thanks.

Signed-off-by: Zheng Yin <zhengyin@cmss.chinamobile.com>
Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- thx

@dillaman dillaman added this to the octopus milestone Feb 26, 2020
@dillaman
Copy link

jenkins test make check

@dillaman dillaman merged commit 1e7e130 into ceph:master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants