Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: Isolate each RBD component #33520

Merged
merged 1 commit into from Mar 13, 2020
Merged

mgr/dashboard: Isolate each RBD component #33520

merged 1 commit into from Mar 13, 2020

Conversation

tspmelo
Copy link
Contributor

@tspmelo tspmelo commented Feb 24, 2020 •
edited by votdev

Before when you accessed any RBD component, you were loading all 4 components
at the same time and each was doing frequent requests to the server.

Now it only loads 1 at a time.

Fixes: https://tracker.ceph.com/issues/44278

Signed-off-by: Tiago Melo tmelo@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@tspmelo tspmelo requested a review from a team as a code owner February 24, 2020 21:38
Devp00l
Devp00l approved these changes Feb 26, 2020
View reviewed changes
Copy link

@Devp00l Devp00l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice improvement :)

@tspmelo tspmelo requested a review from a team March 3, 2020 09:48
mgr/dashboard: Isolate each RBD component
ddf5126 
Before when you accessed any RBD component, you were loading all 4 components
at the same time and each was doing frequent requests to the server.

Now it only loads 1 at a time.

Fixes: https://tracker.ceph.com/issues/44278

Signed-off-by: Tiago Melo <tmelo@suse.com>
@tspmelo tspmelo requested a review from a team as a code owner March 13, 2020 00:19
@tspmelo tspmelo changed the base branch from master to octopus March 13, 2020 00:19
@tspmelo tspmelo added this to the octopus milestone Mar 13, 2020
@tspmelo tspmelo removed the request for review from a team March 13, 2020 00:20
@liewegas liewegas merged commit 48cc552 into ceph:octopus Mar 13, 2020
@tspmelo tspmelo deleted the wip-rbd-tabs branch March 13, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Devp00l Devp00l Devp00l approved these changes

Assignees
No one assigned
Labels
dashboard needs-review wip-sage-testing
Projects
None yet
Milestone
octopus
4 participants
@tspmelo @Devp00l @LenzGr @liewegas