Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: Remove ngx-store #33756

Merged
merged 1 commit into from
Mar 9, 2020
Merged

mgr/dashboard: Remove ngx-store #33756

merged 1 commit into from
Mar 9, 2020

Conversation

tspmelo
Copy link
Contributor

@tspmelo tspmelo commented Mar 5, 2020 •
edited by votdev
Loading

This package is only used in one place, doesn't work with Angular 9 and
hasn't been updated in a while.

Fixes: https://tracker.ceph.com/issues/44449

Signed-off-by: Tiago Melo tmelo@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@tspmelo tspmelo requested a review from a team as a code owner March 5, 2020 17:26
@tspmelo
Copy link
Contributor Author

tspmelo commented Mar 5, 2020

jenkins test dashboard

mgr/dashboard: Remove ngx-store
3d2d476 
This package is only used in one place, doesn't work with Angular 9 and
hasn't been updated in a while.

Fixes: https://tracker.ceph.com/issues/44449

Signed-off-by: Tiago Melo <tmelo@suse.com>
@tspmelo tspmelo requested a review from a team March 6, 2020 10:39
@tspmelo
Copy link
Contributor Author

tspmelo commented Mar 6, 2020

jenkins test dashboard

1 similar comment
@tspmelo
Copy link
Contributor Author

tspmelo commented Mar 6, 2020

jenkins test dashboard

epuertat
epuertat approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... but the decorator form was really cute 🤣 Don't we have a service for handling LocalStorage stuff?

@tspmelo
Copy link
Contributor Author

tspmelo commented Mar 6, 2020

maybe we can create our own decorator :)

@alfonsomthd alfonsomthd self-requested a review March 9, 2020 07:57
Devp00l
Devp00l approved these changes Mar 9, 2020
View reviewed changes
Copy link

@Devp00l Devp00l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LenzGr LenzGr merged commit da52dec into ceph:master Mar 9, 2020
@tspmelo tspmelo deleted the wip-remove-ngx-store branch March 9, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfonsomthd alfonsomthd alfonsomthd approved these changes

@Devp00l Devp00l Devp00l approved these changes

@epuertat epuertat epuertat approved these changes

Assignees
No one assigned
Labels
dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tspmelo @alfonsomthd @Devp00l @epuertat @LenzGr