-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nautilus: mgr/dashboard: 'destroyed' view in CRUSH map viewer #33764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenkins test dashboard |
1 similar comment
jenkins test dashboard |
Fixes: https://tracker.ceph.com/issues/44198 Signed-off-by: Avan Thakkar <athakkar@redhat.com> (cherry picked from commit cbb4c62) Conflicts: src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/crushmap/crushmap.component.html div class changed from panel to card Adjusted the test to seek for card-header element
shyukri
force-pushed
the
wip-44327-nautilus
branch
from
March 6, 2020 07:40
e080cec
to
412286e
Compare
epuertat
approved these changes
Mar 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @shyukri !
avanthakkar
approved these changes
Mar 18, 2020
arbtfnf
approved these changes
Mar 19, 2020
epuertat
added a commit
to rhcs-dashboard/ceph
that referenced
this pull request
Apr 20, 2020
Backport ceph#33764 resulted in the mixing of Bootstrap 4 classes into Nautilus dashboard, which is Bootstrap 3 based. This fix reverts most of those unintended changes (see cbb4c62 for understanding the original extent of changes). Fixes: https://tracker.ceph.com/issues/44198 Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
3 tasks
s0nea
pushed a commit
to ceph/ceph-ci
that referenced
this pull request
Apr 22, 2020
Backport ceph/ceph#33764 resulted in the mixing of Bootstrap 4 classes into Nautilus dashboard, which is Bootstrap 3 based. This fix reverts most of those unintended changes (see cbb4c62 for understanding the original extent of changes). Fixes: https://tracker.ceph.com/issues/44198 Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
callithea
added a commit
that referenced
this pull request
May 13, 2020
nautilus: mgr/dashboard: fix backport #33764
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/44327
backport of #33405
parent tracker: https://tracker.ceph.com/issues/44198
this backport was staged using ceph-backport.sh version 15.1.0.1009
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh