qa/tasks/ceph.py: quote "<kind>" in command line #33775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise bash will intepret "kind" as a file when handling command like ``` sudo zgrep <kind> /var/log/ceph/valgrind/* /dev/null | sort | uniq ``` and try to feed its content to zgrep, and write the output of zgrep to /var/log/ceph/valgrind/*. this is not the intended behavior. what we what to do is to pass "<kind>" as an argument to zgrep, along with the globbed files names which matches "/var/log/ceph/valgrind/*". in this change, "<kind>" is quoted as in the command line. it's also what `pipes.quote()` does before the change of 35cf513. this addresses the regression introduced by 35cf513. Fixes: https://tracker.ceph.com/issues/44454 Signed-off-by: Kefu Chai <kchai@redhat.com>
ajarr
approved these changes
Mar 6, 2020
Works now. With this fix, |
|
@ajarr thanks for the review and verification! |
|
that was cool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise bash will intepret "kind" as a file when handling command like
and try to feed its content to zgrep, and write the output of zgrep
to /var/log/ceph/valgrind/. this is not the intended behavior. what we
what to do is to pass "" as an argument to zgrep, along with
the globbed files names which matches "/var/log/ceph/valgrind/".
in this change, "" is quoted as in the command line. it's also
what
pipes.quote()does before the change of35cf513.
this addresses the regression introduced by
35cf513.
Fixes: https://tracker.ceph.com/issues/44454
Signed-off-by: Kefu Chai kchai@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox