rbd-mirror: prevent I/O modifications against a non-primary image #33831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dillaman
changed the title
|
@dillaman unittest_rbd_mirror crashed on jenkins |
|
jenkins test make check |
|
(appended a commit that fixed a random failure in the unit tests due to notifications not getting delivered to rbd-mirror) |
added 13 commits
March 10, 2020 19:23
When a snapshot-based image is non-primary, we will need to use this implicit feature to ensure that writes and maintenance operations cannot be performed against the image. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
This will be utilized by the RefreshRequest state machine to flag the image as read-only if the new RBD_FEATURE_NON_PRIMARY feature is enabled. Also allow that flag to be masked out by rbd-mirror daemon to permit IO and operations against a non-primary image. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
With the non-primary feature bit is enabled, mask-out the read-only feature bit that will be set in the refresh image state machine if the image has that feature bit set. This will ensure that only the rbd-mirror daemon will be able to modify a non-primary image. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
When promoted to primary, disable the non-primary feature bit and when demoted (or created non-primary), enable the non-primary feature bit. This will prevent all non rbd-mirror RBD clients from modifying the RBD image. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
The promote state machine will handle remove the non-primary feature bit and will ensure an interrupted disable operation doesn't leave things in an inconsistent state. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
The exclusive-lock and journaling features are not required for snapshot-based mirroring. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
This variable is not currently used in snapshot-based mirroring mode but it should be populated for consistency. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
The state machine was incorrectly skipping over the mirror enable step for non-primary images when the journaling feature bit was not enabled. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
When using snapshot-based mirroring, there shouldn't be any need to force the use of the exclusive-lock feature. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
…ures Ensure that snapshot-based mirroring is tested in different RBD image feature combinations. Fixes: https://tracker.ceph.com/issues/44396 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
This feature is mutable from only within librbd as a mirrored image is promoted/demoted. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
If a refresh is in-progress when a header update notification is received, the notification was previously incorrectly dropped. This prevented rbd-mirror's snapshot-based mirroring replayer from detecting updates in some cases. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
The non-primary image might have mirror snapshots that need to be updated to remove the peer reference. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
trociny
reviewed
Mar 11, 2020
The new RBD_FEATURE_NON_PRIMARY overlaps with the legacy test for an invalid feature bit. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
|
http://pulpito.ceph.com/jdillaman-2020-03-11_14:09:34-rbd-wip-jd-testing-distro-basic-smithi/ (includes the fast-diff PR and the rbd_support pool scan improvements) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox