qa/vstart_runner: update vstart_runner.LocalRemote.sh

[rishabh-d-dave]

Commit 9f6c764 replaces remote.run calls by remote.sh without
updating the definition of vstart_runner.LocalRemote.sh which breaks the
cephfs tests when executed locally.

Fixes: https://tracker.ceph.com/issues/44579

Checklist

• References tracker ticket
• Updates documentation if necessary
• Includes tests for new functionality or reproducer for bug

---

Show available Jenkins commands

• jenkins retest this please
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test dashboard backend
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox

[rishabh-d-dave]

Tested this PR locally -

2020-03-19 22:44:20,073.073 INFO:__main__:test_issue_cephfs_shell_cmd_at_invocation (tasks.cephfs.test_cephfs_shell.TestMisc) ... ok
2020-03-19 22:44:20,074.074 INFO:__main__:Stopped test: test_issue_cephfs_shell_cmd_at_invocation (tasks.cephfs.test_cephfs_shell.TestMisc) in 17.912043s
2020-03-19 22:44:20,074.074 INFO:__main__:
2020-03-19 22:44:20,074.074 INFO:__main__:----------------------------------------------------------------------
2020-03-19 22:44:20,074.074 INFO:__main__:Ran 1 test in 17.912s
2020-03-19 22:44:20,075.075 INFO:__main__:
2020-03-19 22:44:20,075.075 INFO:__main__:OK

test_issue_cephfs_shell_cmd_at_invocation contains a call to remote.sh (see https://github.com/ceph/ceph/blob/master/qa/tasks/cephfs/test_cephfs_shell.py#L928)

[ukernel]

Works for me

[rishabh-d-dave]

@ukernel Can I please get an approval?

[gregsfortytwo]

Needs a signed-off-by

[rishabh-d-dave]

@gregsfortytwo Added.

[gregsfortytwo]

http://pulpito.ceph.com/gregf-2020-03-26_16:03:14-fs-wip-greg-testing-326-distro-basic-smithi/

Hmm merge conflict with another one of your PRs, perhaps, @rishabh-d-dave?

[gregsfortytwo]

http://pulpito.front.sepia.ceph.com:80/gregf-2020-04-02_05:22:31-fs-wip-greg-testing-41-3-distro-basic-smithi/
Try, try again — Zheng attributes these failures to https://tracker.ceph.com/issues/44904 so I'll fix that up...

[rishabh-d-dave]

In my understanding, this change should affect only how tests run locally. Therefore, I don't see the point in testing this patch with Teuthology.

[gregsfortytwo]

In my understanding, this change should affect only how tests run locally. Therefore, I don't see the point in testing this patch with Teuthology.

Yes, that's technically true. But it doesn't hurt to run it through a QA suite to be sure and there are plenty of times we've had little change that "can't possibly break anything" cause an entire suite of tests to fail, so we like to be cautious unless there's a strong urgent reason not to be. :)

[rishabh-d-dave]

the point in testing this patch with Teuthology.

Yes, that's technically true. But it doesn't hurt to run it through a QA suite to be sure and there are plenty of times we've had little change that "can't possibly break anything" cause an entire suite of tests to fail, so we like to be cautious unless there's a strong urgent reason not to be. :)

Cool. Thank you for the explanation.

[tchaikov]

jenkins test dashboard backend

[tchaikov]

In my understanding, this change should affect only how tests run locally. Therefore, I don't see the point in testing this patch with Teuthology.

FWIW, vstart-runner is also used by the "dashboard backend" jenkins job.

[rishabh-d-dave]

In my understanding, this change should affect only how tests run locally. Therefore, I don't see the point in testing this patch with Teuthology.

FWIW, vstart-runner is also used by the "dashboard backend" jenkins job.

Oh, okay. Wasn't aware of that. Thanks!