cephfs-shell: Fix flake8 errors (E302, E502, E128, F821, W605, 5128, E122) #34254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the following flake8 error:
E302 expected 2 blank lines, found 1
Fixes: https://tracker.ceph.com/issues/44645
Signed-off-by: Dandamudi Rohit <rohitdandamudi.1100@gmail.com>
This patch fixes the following flake8 error: E502 the backslash is redundant between brackets Fixes: https://tracker.ceph.com/issues/44645 Signed-off-by: Dandamudi Rohit <rohitdandamudi.1100@gmail.com>
This patch fixes the following flake8 error:
E302 expected 2 blank lines, found 1
Fixes: https://tracker.ceph.com/issues/44645
Signed-off-by: Dandamudi Rohit <rohitdandamudi.1100@gmail.com>
This patch fixes the following flake8 error:
E128 continuation line under-indented for visual indent
Fixes: https://tracker.ceph.com/issues/44645
Signed-off-by: Dandamudi Rohit <rohitdandamudi.1100@gmail.com>
This patch fixes the following flake8 error:
F821 undefined name 'e'
Fixes: https://tracker.ceph.com/issues/44645
Signed-off-by: Dandamudi Rohit <rohitdandamudi.1100@gmail.com>
This patch fixes the following flake8 error:
W605 invalid escape sequence '\A'
Fixes: https://tracker.ceph.com/issues/44645
Signed-off-by: Dandamudi Rohit <rohitdandamudi.1100@gmail.com>
This patch fixes the following flake8 error:
E128 continuation line under-indented for visual indent
Fixes: https://tracker.ceph.com/issues/44645
Signed-off-by: Dandamudi Rohit <rohitdandamudi.1100@gmail.com>
This patch fixes the following flake8 error:
E122 continuation line missing indentation or outdented
Fixes: https://tracker.ceph.com/issues/44645
Signed-off-by: Dandamudi Rohit <rohitdandamudi.1100@gmail.com>
|
Hello @varshar16 Can you please have a look at it. Also the W605 didn't appear when I ran flake8 command, but corrected it anyway. Thanks |
varshar16
suggested changes
Mar 30, 2020
There was a problem hiding this comment.
The following changes are required:
- In commit cf2cb51, add a blank line before
Fixes. - Use imperative mood in commits.
- Merge commits fixing same error type.
Check the log for examples.
Refer this doc: https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#commit-title
varshar16
reviewed
Mar 30, 2020
| @@ -136,6 +136,7 @@ def ls(path, opts=''): | |||
| perror(e) | |||
| shell.exit_code = e.get_error_code() | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Move this change to a different commit.
varshar16
reviewed
Mar 30, 2020
| @@ -1357,7 +1357,6 @@ class CephFSShell(Cmd): | |||
| else: | |||
| self.perror("snapshot can only be created or deleted; check - " | |||
| "help snap") | |||
| self.exit_code = e.get_error_code() | |||
There was a problem hiding this comment.
This change is wrong. Exit code is required and it should return 1 here .
|
Please fix these errors too: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cephfs-shell: Fix flake8 errors (E302, E502, E128, F821, W605, 5128, E122)
Fixes: https://tracker.ceph.com/issues/44645
Signed-off-by: Dandamudi Rohit rohitdandamudi.1100@gmail.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox