Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cephfs-shell: Fix flake8 errors (E302, E502, E128, F821, W605, 5128, E122) #34254

Closed
wants to merge 8 commits into from
Closed

cephfs-shell: Fix flake8 errors (E302, E502, E128, F821, W605, 5128, E122) #34254

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cf2cb51
cephfs-shell: Added blank line before poutput definition
me-diru Mar 27, 2020
22c126c
cephfs-shell: Removed blackslash between brackets in to_bytes definition
me-diru Mar 27, 2020
246ae69
cephfs-shell: Added blank line before and after ls() definition
me-diru Mar 27, 2020
5355b5e
cephfs-shell: Indent under-intended code in do_du()
me-diru Mar 27, 2020
402f74a
cephfs-shell: Removed unused exception instance in do_snap()
me-diru Mar 27, 2020
e36541b
cephfs-shell: Removed extra backslash in do_stat()
me-diru Mar 27, 2020
44f5f8c
cephfs-shell: Indent under-intened code in do_stat()
me-diru Mar 27, 2020
f5dbcd8
cephfs-shell: Indent outdented code in do_help()
me-diru Mar 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion src/tools/cephfs/cephfs-shell
View file
Open in desktop
Expand Up @@ -1357,7 +1357,6 @@ class CephFSShell(Cmd):
else:
self.perror("snapshot can only be created or deleted; check - "
"help snap")
self.exit_code = e.get_error_code()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is wrong. Exit code is required and it should return 1 here .


def do_help(self, line):
"""
Expand Down