octopus: librbd: fix client backwards compatibility issues #34323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 31, 2020 11:22
The Luminous release did not support adding images to a group (it only included the bare-minimum support for creating groups). Commit f76df32 incorrectly dropped support for ignoring this possible failure. This prevents Nautilus-release clients from opening images contained within a Luminous-release cluster. Fixes: http://tracker.ceph.com/issues/38834 Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 6f29dc6) (cherry picked from commit ab720d4)
We want to support N - 3 client backward compatibility (special case to support Jewel since it was a LTS release). The "get_snapshot_timestamp" cls method does not exist in Jewel clusters so librbd should fallback to excluding the op if it fails. Note that this N - 3 also needs to apply for downstream releases as well, which implies we still need Jewel for the time being. Fixes: http://tracker.ceph.com/issues/39450 Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit c644121) Conflicts: src/test/librbd/image/test_mock_RefreshRequest.cc: tweaked to support pool configs (cherry picked from commit d1a67c3)
yuriw
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.ceph.com/issues/44861