Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/cephadm: Fixed warn_on_stray_hosts setting #34555

Merged
merged 1 commit into from Apr 15, 2020
Merged

mgr/cephadm: Fixed warn_on_stray_hosts setting #34555

merged 1 commit into from Apr 15, 2020
+2 −2

Conversation

ahaase-c4u
Copy link
Contributor

@ahaase-c4u ahaase-c4u commented Apr 14, 2020 •
edited

…set to false.

Fixes: https://tracker.ceph.com/issues/45065

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@ahaase-c4u ahaase-c4u requested a review from a team as a code owner April 14, 2020 15:11
@sebastian-philipp
Copy link
Contributor

sebastian-philipp commented Apr 14, 2020 •
edited

DCO is missing. Mind doing a

git checkout 45065
git commit --amend -s
git push -f

?

@sebastian-philipp sebastian-philipp changed the title Cephadm: Output host_detail and daemon_detail, if corresponding option is not … mgr/cephadm: Output host_detail and daemon_detail, if corresponding option is not … Apr 14, 2020
sebastian-philipp
sebastian-philipp suggested changes Apr 14, 2020
View reviewed changes
src/pybind/mgr/cephadm/module.py Outdated Show resolved Hide resolved
src/pybind/mgr/cephadm/module.py Outdated Show resolved Hide resolved
@sebastian-philipp sebastian-philipp changed the title mgr/cephadm: Output host_detail and daemon_detail, if corresponding option is not … mgr/cephadm: Fixed warn_on_stray_hosts setting Apr 14, 2020
@ahaase-c4u
mgr/cephadm: Fixed warn_on_stray_hosts setting
b07c2da 
Fixes: https://tracker.ceph.com/issues/45065
Signed-off-by: Andreas Haase <andreas.haase@community4you.de>
@mgfritch
Copy link
Contributor

QA run successful. failure is unrelated.

http://pulpito.ceph.com/mgfritch-2020-04-15_00:22:19-rados-wip-mgfritch-testing-2020-04-14-1709-distro-basic-smithi/

@sebastian-philipp sebastian-philipp merged commit dce6285 into ceph:master Apr 15, 2020
@sebastian-philipp sebastian-philipp mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-philipp sebastian-philipp sebastian-philipp approved these changes

Assignees
No one assigned
Labels
cephadm
Projects
None yet
Milestone
No milestone
3 participants
@ahaase-c4u @sebastian-philipp @mgfritch