Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/cephadm: Fixed warn_on_stray_hosts setting #34555

Merged
merged 1 commit into from Apr 15, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pybind/mgr/cephadm/module.py
Expand Up @@ -1069,7 +1069,7 @@ def _check_for_strays(self):
host_detail.append(
'stray host %s has %d stray daemons: %s' % (
host, len(missing_names), missing_names))
if host_detail:
if self.warn_on_stray_hosts and host_detail:
self.health_checks['CEPHADM_STRAY_HOST'] = {
'severity': 'warning',
'summary': '%d stray host(s) with %s daemon(s) '
Expand All @@ -1078,7 +1078,7 @@ def _check_for_strays(self):
'count': len(host_detail),
'detail': host_detail,
}
if daemon_detail:
if self.warn_on_stray_daemons and daemon_detail:
self.health_checks['CEPHADM_STRAY_DAEMON'] = {
'severity': 'warning',
'summary': '%d stray daemons(s) not managed by cephadm' % (
Expand Down