octopus: mgr/telegraf: catch FileNotFoundError exception #34629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in tasks/module_selftest.yaml, `TestModuleSelftest.test_telegraf()` is called. but we fail to prepare a unix domain socket to which the telegraf module can send stats. and telegraf module does not catch FileNotFoundError exception, so the exception is populated to ceph-mgr and is found by the test, hence the test is marked a failure whenever telegraf is tested. in this change, * catch this exception, so it won't be caught by ceph-mgr * whitelist the error message, so the test can pass Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit f6d028d)
neha-ojha
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/45069
backport of #34468
parent tracker: https://tracker.ceph.com/issues/43551
this backport was staged using ceph-backport.sh version 15.1.1.389
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh