octopus: core: osd: prevent ShardedOpWQ suicide_grace drop when waiting for work. #34881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Sharded OpWQ will opportunistically wait for more work when processing an empty queue. While waiting, the default work queue heartbeat timeout and suicide_grace values are modified. The `threadpool_default_timeout` grace is applied and suicide_grace is disabled. If this op hangs, the heartbeat watchdog will not trigger an OSD suicide recovery. The default work queue values for grace and suicide_grace are re-applied after finding work. This keeps the heartbeat timeouts consistent with the values applied on _process() entry. Fixes: https://tracker.ceph.com/issues/45076 Signed-off-by: Dan Hill <daniel.hill@canonical.com> (cherry picked from commit 85f6e8d)
|
@ceph/backport-admins |
jdurgin
approved these changes
May 4, 2020
neha-ojha
approved these changes
May 4, 2020
smithfarm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/45357
backport of #34575
parent tracker: https://tracker.ceph.com/issues/45076
this backport was staged using ceph-backport.sh version 15.1.1.389
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh