Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: Use ng-bootstrap for Alert #35297

Merged
merged 1 commit into from Jun 5, 2020
Merged

mgr/dashboard: Use ng-bootstrap for Alert #35297

merged 1 commit into from Jun 5, 2020

Conversation

tspmelo
Copy link
Contributor

@tspmelo tspmelo commented May 28, 2020

Fixes: https://tracker.ceph.com/issues/45751

Signed-off-by: Tiago Melo tmelo@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@tspmelo tspmelo requested a review from a team as a code owner May 28, 2020 19:07
@tspmelo
Copy link
Contributor Author

tspmelo commented May 28, 2020

jenkins test dashboard

@avanthakkar
Copy link
Contributor

jenkins test dashboard

Devp00l
Devp00l approved these changes Jun 3, 2020
View reviewed changes
Copy link

@Devp00l Devp00l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement :)

@tspmelo tspmelo requested a review from a team June 3, 2020 10:52
@tspmelo
Copy link
Contributor Author

tspmelo commented Jun 4, 2020

jenkins test dashboard backend

mgr/dashboard: Use ng-bootstrap for Alert
9ad9828 
Fixes: https://tracker.ceph.com/issues/45751

Signed-off-by: Tiago Melo <tmelo@suse.com>
@LenzGr LenzGr merged commit bfd46d7 into ceph:master Jun 5, 2020
@tspmelo tspmelo deleted the wip-alert branch June 5, 2020 08:50
s0nea pushed a commit to s0nea/ceph that referenced this pull request Jun 26, 2020
mgr/dashboard: support >1 top notification panels
afcfb08 
Update navigation component in order to show more than
one notification panel on top of the page.

Signed-off-by: Tatjana Dehler <tdehler@suse.com>
(cherry picked from commit 455dca6)

Conflicts:
	src/pybind/mgr/dashboard/frontend/src/app/shared/components/pwd-expiration-notification/pwd-expiration-notification.component.html
	The alert component has been migrated from ngx-bootstrap to ng-boostrap in master: ceph#35297
s0nea pushed a commit to s0nea/ceph that referenced this pull request Jun 26, 2020
mgr/dashboard: add telemetry activation notification
7ab616a 
The commit adds 2 different parts to show the
Telemetry activation notification in the dashboard:

1. The Telemetry activation notification component
   itself. It contains the definition of the
   notification panel.
2. The Telemetry notification service. The service
   is needed to be able to show/hide the
   notification from:
   * the component itself (e.g. when clicking the
     button button)
   * the Telemetry configuration component (when
     enabling/disabling Telemetry)
   * the navigation component (to set the css-
     classes accordingly)

Fixes: https://tracker.ceph.com/issues/45464
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
(cherry picked from commit f7e4579)

Conflicts:
	src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/telemetry/telemetry.component.ts
	A form loading directive has been introduced in master: ceph#34746

	src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.spec.ts
	The test configuration has been improved in master: ceph#34965

	src/pybind/mgr/dashboard/frontend/src/app/shared/components/telemetry-notification/telemetry-notification.component.html
	src/pybind/mgr/dashboard/frontend/src/app/shared/components/telemetry-notification/telemetry-notification.component.spec.ts
	The alert component has been migrated from ngx-bootstrap to ng-boostrap in master: ceph#35297
	TestBed.get has been replaced by TestBed.inject in master: ceph#34934

	src/pybind/mgr/dashboard/frontend/src/app/shared/services/telemetry-notification.service.spec.ts
	TestBed.get has been replaced by TestBed.inject in master: ceph#34934
s0nea pushed a commit to s0nea/ceph that referenced this pull request Jun 26, 2020
mgr/dashboard: support >1 top notification panels
6e5e2c1 
Update navigation component in order to show more than
one notification panel on top of the page.

Signed-off-by: Tatjana Dehler <tdehler@suse.com>
(cherry picked from commit 455dca6)

Conflicts:
	src/pybind/mgr/dashboard/frontend/src/app/shared/components/pwd-expiration-notification/pwd-expiration-notification.component.html
	The alert component has been migrated from ngx-bootstrap to ng-boostrap in master: ceph#35297
s0nea pushed a commit to s0nea/ceph that referenced this pull request Jun 26, 2020
mgr/dashboard: add telemetry activation notification
3709f7f 
The commit adds 2 different parts to show the
Telemetry activation notification in the dashboard:

1. The Telemetry activation notification component
   itself. It contains the definition of the
   notification panel.
2. The Telemetry notification service. The service
   is needed to be able to show/hide the
   notification from:
   * the component itself (e.g. when clicking the
     button button)
   * the Telemetry configuration component (when
     enabling/disabling Telemetry)
   * the navigation component (to set the css-
     classes accordingly)

Fixes: https://tracker.ceph.com/issues/45464
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
(cherry picked from commit f7e4579)

Conflicts:
	src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/telemetry/telemetry.component.ts
	A form loading directive has been introduced in master: ceph#34746

	src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.spec.ts
	The test configuration has been improved in master: ceph#34965

	src/pybind/mgr/dashboard/frontend/src/app/shared/components/telemetry-notification/telemetry-notification.component.html
	src/pybind/mgr/dashboard/frontend/src/app/shared/components/telemetry-notification/telemetry-notification.component.spec.ts
	The alert component has been migrated from ngx-bootstrap to ng-boostrap in master: ceph#35297
	TestBed.get has been replaced by TestBed.inject in master: ceph#34934

	src/pybind/mgr/dashboard/frontend/src/app/shared/services/telemetry-notification.service.spec.ts
	TestBed.get has been replaced by TestBed.inject in master: ceph#34934
@s0nea s0nea mentioned this pull request Jul 24, 2020
Merged
s0nea pushed a commit to s0nea/ceph that referenced this pull request Jul 29, 2020
mgr/dashboard: add telemetry activation notification
4952bf6 
The commit adds 2 different parts to show the
Telemetry activation notification in the dashboard:

1. The Telemetry activation notification component
   itself. It contains the definition of the
   notification panel.
2. The Telemetry notification service. The service
   is needed to be able to show/hide the
   notification from:
   * the component itself (e.g. when clicking the
     button button)
   * the Telemetry configuration component (when
     enabling/disabling Telemetry)
   * the navigation component (to set the css-
     classes accordingly)

Fixes: https://tracker.ceph.com/issues/45464
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
(cherry picked from commit f7e4579)

Conflicts:
	src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/telemetry/telemetry.component.ts
	A form loading directive has been introduced in master: ceph#34746

	src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.spec.ts
	The test configuration has been improved in master: ceph#34965

	src/pybind/mgr/dashboard/frontend/src/app/shared/components/telemetry-notification/telemetry-notification.component.html
	src/pybind/mgr/dashboard/frontend/src/app/shared/components/telemetry-notification/telemetry-notification.component.spec.ts
	The alert component has been migrated from ngx-bootstrap to ng-boostrap in master: ceph#35297
	TestBed.get has been replaced by TestBed.inject in master: ceph#34934

	src/pybind/mgr/dashboard/frontend/src/app/shared/services/telemetry-notification.service.spec.ts
	TestBed.get has been replaced by TestBed.inject in master: ceph#34934

The backport contains one commit less (39a26ae
is missing) than the original pull request because the migration from alert to
ngb-alert (ceph#35297) has not been backported.
s0nea pushed a commit to s0nea/ceph that referenced this pull request Aug 11, 2020
mgr/dashboard: support >1 top notification panels
5c13111 
Update navigation component in order to show more than
one notification panel on top of the page.

Signed-off-by: Tatjana Dehler <tdehler@suse.com>
(cherry picked from commit 455dca6)

Conflicts:
	src/pybind/mgr/dashboard/frontend/src/app/shared/components/pwd-expiration-notification/pwd-expiration-notification.component.html
	The alert component has been migrated from ngx-bootstrap to ng-boostrap in master: ceph#35297
s0nea pushed a commit to s0nea/ceph that referenced this pull request Aug 11, 2020
mgr/dashboard: add telemetry activation notification
f823d72 
The commit adds 2 different parts to show the
Telemetry activation notification in the dashboard:

1. The Telemetry activation notification component
   itself. It contains the definition of the
   notification panel.
2. The Telemetry notification service. The service
   is needed to be able to show/hide the
   notification from:
   * the component itself (e.g. when clicking the
     button button)
   * the Telemetry configuration component (when
     enabling/disabling Telemetry)
   * the navigation component (to set the css-
     classes accordingly)

Fixes: https://tracker.ceph.com/issues/45464
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
(cherry picked from commit f7e4579)

Conflicts:
	src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/telemetry/telemetry.component.ts
	A form loading directive has been introduced in master: ceph#34746

	src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.spec.ts
	The test configuration has been improved in master: ceph#34965

	src/pybind/mgr/dashboard/frontend/src/app/shared/components/telemetry-notification/telemetry-notification.component.html
	src/pybind/mgr/dashboard/frontend/src/app/shared/components/telemetry-notification/telemetry-notification.component.spec.ts
	The alert component has been migrated from ngx-bootstrap to ng-boostrap in master: ceph#35297
	TestBed.get has been replaced by TestBed.inject in master: ceph#34934

	src/pybind/mgr/dashboard/frontend/src/app/shared/services/telemetry-notification.service.spec.ts
	TestBed.get has been replaced by TestBed.inject in master: ceph#34934

The backport contains one commit less (39a26ae
is missing) than the original pull request because the migration from alert to
ngb-alert (ceph#35297) has not been backported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Devp00l Devp00l Devp00l approved these changes

@epuertat epuertat epuertat approved these changes

Assignees
No one assigned
Labels
dashboard
Projects
None yet
Milestone
No milestone
5 participants
@tspmelo @avanthakkar @Devp00l @epuertat @LenzGr