Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/cephadm: set Ganesha pool/namespace settings in the Dashboard #35538

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

bk201
Copy link
Contributor

@bk201 bk201 commented Jun 11, 2020

  • Config Ganesha pool and namespace settings in Dashboard.
  • New config_dashboard option in cephadm. If the flag is Flase,
    cephadm won't manage Dashboard settings for daemons. This might be
    useful when users want to config API URLs by themselves or for debugging.

Fixes: https://tracker.ceph.com/issues/45155
Signed-off-by: Kiefer Chang kiefer.chang@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@bk201 bk201 requested a review from a team as a code owner June 11, 2020 10:48
- Config Ganesha pool and namespace settings in Dashboard.
- New `config_dashboard` option in cephadm. If the flag is Flase,
  cephadm won't manage Dashboard settings for daemons. This might be
  useful when users want to config API URLs by themselves or for debugging.

Fixes: https://tracker.ceph.com/issues/45155
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
@bk201
Copy link
Contributor Author

bk201 commented Jun 12, 2020

If services are destroyed, the settings in Dashboard are not removed.
If there is no daemon, current configuring paths are not entered, need to find other ways to handle this. An issue was created to track this: https://tracker.ceph.com/issues/45982

@sebastian-philipp
Copy link
Contributor

If services are destroyed, the settings in Dashboard are not removed.
If there is no daemon, current configuring paths are not entered, need to find other ways to handle this. An issue was created to track this: https://tracker.ceph.com/issues/45982

cc @jschmid1

@DanielQujun
Copy link

@sebastian-philipp @bk201 hey, Guys, I don't con with this PR fix the issue, If we take a look at the Traceback:

AttributeError: 'ServiceDescription' object has no attribute 'service'

It certainly says that is a no attribute Exception, I have look through the code on the master branch, the service attribute does not exist in 'ServiceDescription' object, I think there are must be something wrong, could you please inspect it?

@sebastian-philipp
Copy link
Contributor

maybe #36683 helps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants