mgr/dashboard: Fixes regression in device selection modal #35875
Conversation
The 'ExpressionChangedAfterItHasBeenCheckedError' has recently shown up in device selection modal in OSD creation form. It looks like it's a regression due to the modal switch (PR ceph#35370). Which was merged yesterday and it had worked on Monday. Fixes: https://tracker.ceph.com/issues/46303 Signed-off-by: Stephan Müller <smueller@suse.com>
|
jenkins test dashboard backend |
| // Fixes 'ExpressionChangedAfterItHasBeenCheckedError' | ||
| setTimeout(() => { | ||
| this.requiredFilters = _.map(cols, 'name'); | ||
| }, 0); |
There was a problem hiding this comment.
Thanks for fixing the issue.
If this hack is needed, I wonder if the design was right when I implemented this...
There was a problem hiding this comment.
It's now needed because of the modal change. It seems like the new modal initializes the modal somehow in one step with all other components used at the same time (which of course is faster but has downsides). Through the new behavior will set requieredFilters multiple times in one run, which causes the error. The timeout just adds an extra "frame" that forces the template to update after all that is triggered is executed. This way we don't change the variable more than once in a template run.
Before that change your implementation worked fine 👍
|
jenkins test dashboard backend |
The 'ExpressionChangedAfterItHasBeenCheckedError' has recently
shown up in device selection modal in OSD creation form. It looks
like it's a regression due to the modal switch (PR #35370). Which was
merged yesterday and it had worked on Monday.
Fixes: https://tracker.ceph.com/issues/46303
Signed-off-by: Stephan Müller smueller@suse.com
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox