mgr/cephadm: allow to map existing daemons to osdspecs #35945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschmid1
force-pushed
the
osdspec_limit_fixes
branch
2 times, most recently
from
e294d01
to
3c42712
Compare
jschmid1
commented
Jul 9, 2020
sebastian-philipp
suggested changes
Jul 14, 2020
jschmid1
force-pushed
the
osdspec_limit_fixes
branch
from
3c42712
to
f9a3f5e
Compare
|
jenkins retest this please |
jschmid1
force-pushed
the
osdspec_limit_fixes
branch
from
f9a3f5e
to
a9b3650
Compare
3 tasks
jschmid1
commented
Jul 31, 2020
jschmid1
force-pushed
the
osdspec_limit_fixes
branch
2 times, most recently
from
be90ccd
to
b72bba5
Compare
added 2 commits
August 3, 2020 10:04
Fixes: https://tracker.ceph.com/issues/44888 Signed-off-by: Joshua Schmid <jschmid@suse.de>
Fixes: https://tracker.ceph.com/issues/44888 Signed-off-by: Joshua Schmid <jschmid@suse.de>
jschmid1
force-pushed
the
osdspec_limit_fixes
branch
from
b72bba5
to
6bfc458
Compare
|
@jan--f Is there a way to verify that ceph-volume still works with this change? |
|
ping @jan--f |
|
I don't think so no. Once we get #34740 merged I'll add proper support for testing c-v via the teuthology cephadm task. A review would be appreciated. |
sebastian-philipp
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joshua Schmid jschmid@suse.de
with https://tracker.ceph.com/issues/44755 finally being handled, this enables us to implement the
limitkey in osdspecs/drivegroups properly.Fixes: https://tracker.ceph.com/issues/44888
Depends on
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox