mds: do not raise "client failing to respond to cap release" when client working set is reasonable #36501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make this easier to catch. It is still a RuntimeError so it should not affect current tests by default. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
fullerdj
approved these changes
Aug 6, 2020
|
Fixed some tox errors. |
batrick
added a commit
to batrick/ceph
that referenced
this pull request
Aug 6, 2020
* refs/pull/36501/head: qa: add tests for mds_min_caps_working_set mds: add working set minimum for caps qa: use config_set/config_get qa: do not append file names to dirname qa: add exception for test timeouts Reviewed-by: Douglas Fuller <dfuller@redhat.com>
batrick
added a commit
to batrick/ceph
that referenced
this pull request
Aug 7, 2020
* refs/pull/36501/head: qa: add tests for mds_min_caps_working_set mds: add working set minimum for caps qa: use config_set/config_get qa: do not append file names to dirname qa: add exception for test timeouts Reviewed-by: Douglas Fuller <dfuller@redhat.com>
Otherwise the files generated are not actually under the sub-directory! This is correcting a confusing aspect of the test infrastructure but doesn't actually require any changes to the tests. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
It's simpler and does not require MDS restarts. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
A client may hold many inodes pinned in its cache for open files. That client may be unable to release those caps to respond to cache pressure from the MDS (or quiescent client cap recall). We should not complain if that number of capabilities is reasonable (< 10k by default). Fixes: https://tracker.ceph.com/issues/46830 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
|
fs suite run has nothing new except some upgrade test failures (which are known to recently occur). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox