Replace 'whitelist' and 'blacklist' language

[neha-ojha]

This is a rebased version of #35628 with additional changes.

[asettle]

Hi @neha-ojha - whilst I am in agreement with the fundamental changes here, I think further thought should go into the choices of language. Reposting my comment/suggestion that was in the other PR:

• "Ignore" can be interpreted as both "ignore this, let them in" or "ignore this, do not let them in".
• To use 'ignorelist' as a verb is strange, we would recommend 'allow'. To use 'ignorelist' as a noun has a wrong meaning, one can think
  that 'ignorelisted' members will be ignore, when the contrary is true

[epuertat]

Not sure if this has already been discussed and settled, but I still find that ignorelist-blocklist lacks the clarity of allowlist-denylist (e.g.: as in kubernetes/kubernetes#90277).

[neha-ojha]

Hi @neha-ojha - whilst I am in agreement with the fundamental changes here, I think further thought should go into the choices of language. Reposting my comment/suggestion that was in the other PR:

• "Ignore" can be interpreted as both "ignore this, let them in" or "ignore this, do not let them in".
• To use 'ignorelist' as a verb is strange, we would recommend 'allow'. To use 'ignorelist' as a noun has a wrong meaning, one can think
  that 'ignorelisted' members will be ignore, when the contrary is true

Hi @asettle, I totally understand where you are coming from but I believe the essence of this change resonates with you. ignorelist in this context refers to list of strings that we want tests to ignore when looking for real bugs/issues and if it helps we can make that very clear by documenting it. In hindsight, perhaps, log-whitelist wasn't the right term for it in the first place.

[neha-ojha]

No related failures in rados:

https://pulpito.ceph.com/nojha-2020-08-07_22:18:45-rados-wip-35628-2020-08-07-distro-basic-smithi/
rerun - https://pulpito.ceph.com/nojha-2020-08-10_20:26:26-rados-wip-35628-2020-08-07-distro-basic-smithi/

[neha-ojha]

changelog:

• resolved conflict in src/client/Client.cc and src/client/Client.h

[batrick]

@LenzGr how would you like to handle these:

src/pybind/mgr/dashboard/.pylintrc:# Add files or directories to the blacklist. They should be base names, not
src/pybind/mgr/dashboard/.pylintrc:# Add files or directories matching the regex patterns to the blacklist. The
src/pybind/mgr/dashboard/controllers/auth.py:        JwtManager.blacklist_token(token)
src/pybind/mgr/dashboard/frontend/.stylelintrc:    "scss/at-import-partial-extension-blacklist": null,
src/pybind/mgr/dashboard/frontend/tslint.json:    "import-blacklist": [true, "rxjs/Rx", {"@angular/core/testing": ["async"]}],
src/pybind/mgr/dashboard/services/auth.py:    JWT_TOKEN_BLACKLIST_KEY = "jwt_token_black_list"
src/pybind/mgr/dashboard/services/auth.py:            if not JwtManager.is_blacklisted(dtoken['jti']):
src/pybind/mgr/dashboard/services/auth.py:    def blacklist_token(cls, token):
src/pybind/mgr/dashboard/services/auth.py:        blacklist_json = mgr.get_store(cls.JWT_TOKEN_BLACKLIST_KEY)
src/pybind/mgr/dashboard/services/auth.py:        if not blacklist_json:
src/pybind/mgr/dashboard/services/auth.py:            blacklist_json = "{}"
src/pybind/mgr/dashboard/services/auth.py:        bl_dict = json.loads(blacklist_json)
src/pybind/mgr/dashboard/services/auth.py:        mgr.set_store(cls.JWT_TOKEN_BLACKLIST_KEY, json.dumps(bl_dict))
src/pybind/mgr/dashboard/services/auth.py:    def is_blacklisted(cls, jti):
src/pybind/mgr/dashboard/services/auth.py:        blacklist_json = mgr.get_store(cls.JWT_TOKEN_BLACKLIST_KEY)
src/pybind/mgr/dashboard/services/auth.py:        if not blacklist_json:
src/pybind/mgr/dashboard/services/auth.py:            blacklist_json = "{}"
src/pybind/mgr/dashboard/services/auth.py:        bl_dict = json.loads(blacklist_json)
src/pybind/mgr/dashboard/tests/test_rest_tasks.py:# pylint: disable=blacklisted-name
src/pybind/mgr/dashboard/tests/test_tools.py:# pylint: disable=blacklisted-name

[batrick]

@neha-ojha there's also the use of "whiteout" term within the osd. Can you think of a better name for that?

[neha-ojha]

changelog:

• resolved conflict in PendingReleaseNotes

[neha-ojha]

jenkins test dashboard