Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: rgw: fix double slash (//) killing the gateway #36682

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

BryceCao
Copy link
Contributor

backport tracker: https://tracker.ceph.com/issues/46967

backport of #35792
parent tracker: https://tracker.ceph.com/issues/41225

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

When a bucket is inialized as a static website, a curl request on the bucket with double slash kills the gateway.
The problem is on the URL handling of the subdirectory, which tries to remove the last slash of any URL, so when only / is given as a sub-directory, this results to an empty string.

Fixes: https://tracker.ceph.com/issues/41225
Signed-off-by: Theofilos Mouratidis <t.mour@cern.ch>
(cherry picked from commit 626330c)
@dang dang changed the title rgw: fix double slash (//) killing the gateway nautilus: rgw: fix double slash (//) killing the gateway Aug 17, 2020
@BryceCao
Copy link
Contributor Author

@ivancich @cbodley backport for nautilus which is same with #36654 you reviewed a few days ago

@smithfarm smithfarm added this to the nautilus milestone Aug 19, 2020
@smithfarm smithfarm added rgw nautilus-batch-1 nautilus point releases needs-qa labels Aug 19, 2020
@yuriw
Copy link
Contributor

yuriw commented Aug 24, 2020

@yuriw yuriw merged commit c806076 into ceph:nautilus Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants